Rollup of 9 pull requests #141561

jhpratt · 2025-05-25T21:56:40Z

Successful merges:

Implement normalize_lexically #134696 (Implement normalize_lexically)
Add methods to TCP and UDP sockets to modify hop limit (refresh of #94678) #138744 (Add methods to TCP and UDP sockets to modify hop limit (refresh of add methods to TCP and UDP sockets to modify hop limit #94678))
Simplify attribute_groups #140539 (Simplify attribute_groups)
[rustdoc] Unify type aliases rendering with other ADT #140863 ([rustdoc] Unify type aliases rendering with other ADT)
Clarify WTF-8 safety docs #140936 (Clarify WTF-8 safety docs)
Specify that split_ascii_whitespace uses the same definition as is_ascii_whitespace #140952 (Specify that split_ascii_whitespace uses the same definition as is_ascii_whitespace)
Attempt to improve the std::fs::create_dir_all docs related to atomicity #141472 (Attempt to improve the std::fs::create_dir_all docs related to atomicity)
ci: move PR job x86_64-gnu-tools to codebuild #141502 (ci: move PR job x86_64-gnu-tools to codebuild)
const-check: stop recommending the use of rustc_allow_const_fn_unstable #141559 (const-check: stop recommending the use of rustc_allow_const_fn_unstable)

r? @ghost
@rustbot modify labels: rollup

Co-authored-by: David Tolnay <[email protected]>

…cii_whitespace

There only needs to be one `Fn` per symbol, not multiple.

Some are too long (> 100 chars), some are too short, some are missing full stops, some are missing upper-case letters at the start of sentences.

In several files they are entirely unnecessary, with the relevant names already imported. And in a few I have added the necessary `use` item.

…=workingjubilee Implement `normalize_lexically` Implements rust-lang#134694 This is, I think, the most straightforward implementation I could do, which will hopefully more easily allow experimentation if we decide to change the design here.

…=dtolnay Add methods to TCP and UDP sockets to modify hop limit (refresh of rust-lang#94678) rust-lang#94678 was closed because of time constraints of the original author (`@kckeiks).` This PR is a refresh of rust-lang#94678 where the original proposed changes are ported to the current status of the standard library. In addition, this PR: - implements the change suggested in rust-lang#94678 (comment) - defines `set_multicast_hop_limit_v6` and `multicast_hop_limit_v6 ` only for UDP sockets and not for TCP sockets as originally proposed Issue: rust-lang#139166

…ups, r=jdonszelmann Simplify `attribute_groups` It's more complicated than it needs to be. r? `@jdonszelmann`

…der, r=lolbinarycat [rustdoc] Unify type aliases rendering with other ADT Fixes rust-lang#140739. Better reviewed one commit at a time. Just one thing I'm wondering: should we also render non-`repr` attributes? If so, I wonder if we shouldn't simply change `clean::TypeAlias` to contain the other ADT directly (`Struct`, `Enum` and `Union`) and remove the `TypeAlias::generics` field. Can be done in a follow-up too. cc `@camelid` r? `@notriddle`

…kingjubilee Clarify WTF-8 safety docs This PR is a follow-up to PR rust-lang#140159, which clarifies ~~two things~~: - the WTF-8 safety comment [was confusing](rust-lang#140159 (comment)), either surrogate condition is actually sufficient for safety, both are not required - ~~the private `os_str::Slice` type name is easily confused with `std::slice`~~ ~~Happy to bikeshed the `OsSlice` name, other alternatives are `OsStrSlice` and `StrSlice`. Now it's got a distinct name from `std::slice`, it's easy to search and replace.~~ cc `@thaliaarchi` `@workingjubilee`

…tion, r=dtolnay Specify that split_ascii_whitespace uses the same definition as is_ascii_whitespace

Attempt to improve the `std::fs::create_dir_all` docs related to atomicity The original paragraph was added in rust-lang#124520. It doesn't match the actual code logic. It says "function returns an error" if "the parent components" _(which also implies directories)_ "have been created already". The code is as follows: https://github.com/rust-lang/rust/blob/e88e85463468ce5d5ce468414eb69e3b15fa8d42/library/std/src/fs.rs#L3146 https://github.com/rust-lang/rust/blob/e88e85463468ce5d5ce468414eb69e3b15fa8d42/library/std/src/fs.rs#L3160 These lines suppress all errors if any path component is a directory. I've updated the paragraph to mirror this.

…ld, r=Kobzol ci: move PR job x86_64-gnu-tools to codebuild

…_unstable, r=compiler-errors const-check: stop recommending the use of rustc_allow_const_fn_unstable I have seen way too many people see the compiler suggest this attribute and then just apply it without a second thought. This is bad. So let's just stop recommending it; for the rare case where someone needs it, they'll eventually ask us and that way we can be sure that it is truly needed. The dev-guide still also explains `rustc_allow_const_fn_unstable`. Cc `@rust-lang/wg-const-eval`

jhpratt · 2025-05-25T21:56:51Z

@bors r+ rollup=never p=5

bors · 2025-05-25T21:56:53Z

📌 Commit 8fcd1a7 has been approved by jhpratt

It is now in the queue for this repository.

bors · 2025-05-26T00:18:41Z

⌛ Testing commit 8fcd1a7 with merge 33e2813...

Rollup of 9 pull requests Successful merges: - #134696 (Implement `normalize_lexically`) - #138744 (Add methods to TCP and UDP sockets to modify hop limit (refresh of #94678)) - #140539 (Simplify `attribute_groups`) - #140863 ([rustdoc] Unify type aliases rendering with other ADT) - #140936 (Clarify WTF-8 safety docs) - #140952 (Specify that split_ascii_whitespace uses the same definition as is_ascii_whitespace) - #141472 (Attempt to improve the `std::fs::create_dir_all` docs related to atomicity) - #141502 (ci: move PR job x86_64-gnu-tools to codebuild) - #141559 (const-check: stop recommending the use of rustc_allow_const_fn_unstable) r? `@ghost` `@rustbot` modify labels: rollup

rust-log-analyzer · 2025-05-26T01:15:09Z

The job dist-various-2 failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)


error[E0425]: cannot find value `IPV6_MULTICAST_HOPS` in crate `c`
   --> library/std/src/sys/net/connection/socket.rs:817:53
    |
817 |         setsockopt(&self.inner, c::IPPROTO_IPV6, c::IPV6_MULTICAST_HOPS, limit as c_int)
    |                                                     ^^^^^^^^^^^^^^^^^^^ help: a constant with a similar name exists: `IPV6_MULTICAST_LOOP`
    |
   ::: /rust/deps/libc-0.2.172/src/wasi/p2.rs:117:1
    |
117 | pub const IPV6_MULTICAST_LOOP: c_int = 19;
    | ------------------------------------ similarly named constant `IPV6_MULTICAST_LOOP` defined here

error[E0425]: cannot find value `IPV6_MULTICAST_HOPS` in crate `c`
   --> library/std/src/sys/net/connection/socket.rs:821:70
    |
821 |         let raw: c_int = getsockopt(&self.inner, c::IPPROTO_IPV6, c::IPV6_MULTICAST_HOPS)?;
    |                                                                      ^^^^^^^^^^^^^^^^^^^ help: a constant with a similar name exists: `IPV6_MULTICAST_LOOP`
    |
   ::: /rust/deps/libc-0.2.172/src/wasi/p2.rs:117:1
    |
117 | pub const IPV6_MULTICAST_LOOP: c_int = 19;
    | ------------------------------------ similarly named constant `IPV6_MULTICAST_LOOP` defined here

bors · 2025-05-26T01:15:45Z

💔 Test failed - checks-actions

Mallets and others added 30 commits March 20, 2025 11:59

Refresh of rust-lang#94678

5ce4d0d

Use IPv6 addresses in hop_limit_v6 docs

03aef02

Update tracking issue to 139166

5ace46a

Update docs according to PR review

25fb525

Co-authored-by: David Tolnay <[email protected]>

Fix unused_variables

6657c75

Specify that split_ascii_whitespace uses the same definition as is_as…

9a0c856

…cii_whitespace

Fix confusing WTF surrogate safety docs

8f0522d

Introduce some typedefs to improve readability.

e139d26

Simplify Accepts.

5b808b7

There only needs to be one `Fn` per symbol, not multiple.

Fix up some comments.

1525f54

Some are too long (> 100 chars), some are too short, some are missing full stops, some are missing upper-case letters at the start of sentences.

Avoid rustc_span:: qualifiers.

354b1cb

In several files they are entirely unnecessary, with the relevant names already imported. And in a few I have added the necessary `use` item.

ci: move PR job x86_64-gnu-tools to codebuild

ec5e841

improve the std::fs::create_dir_all docs related to atomicity

6d47489

Implement normalize lexically

c299e29

Rename clean::Enum::variants method into non_stripped_variants

5f857a9

Unify rendering of type aliases without ADT items

560aec1

Split Item::attributes method into three

4194745

Rename the document_* argument/field into is_type_alias

eb9f054

Tweak attribute rendering depending on wether or not it is a type alias

4f3dd7b

Add regression test for rust-lang#140739

2b292d1

Improve code

3646a09

Update to new API

ec97b0f

const-check: stop recommending the use of rustc_allow_const_fn_unstable

cf9ac0e

Rollup merge of rust-lang#140539 - nnethercote:simplify-attribute_gro…

e2beb96

…ups, r=jdonszelmann Simplify `attribute_groups` It's more complicated than it needs to be. r? `@jdonszelmann`

Rollup merge of rust-lang#140952 - SimonSapin:ascii_whitespace_defini…

25e04e0

…tion, r=dtolnay Specify that split_ascii_whitespace uses the same definition as is_ascii_whitespace

jhpratt added 2 commits May 25, 2025 23:56

Rollup merge of rust-lang#141502 - marcoieni:x86_64-gnu-tools-codebui…

5796f12

…ld, r=Kobzol ci: move PR job x86_64-gnu-tools to codebuild

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 25, 2025

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels May 26, 2025

jhpratt closed this May 26, 2025

jhpratt deleted the rollup-1yjbnkh branch May 26, 2025 01:37

jhpratt mentioned this pull request May 26, 2025

Add methods to TCP and UDP sockets to modify hop limit (refresh of #94678) #138744

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Rollup of 9 pull requests #141561

Rollup of 9 pull requests #141561

Uh oh!

jhpratt commented May 25, 2025 •

edited by rustbot

Loading

Uh oh!

jhpratt commented May 25, 2025

Uh oh!

bors commented May 25, 2025

Uh oh!

bors commented May 26, 2025

Uh oh!

rust-log-analyzer commented May 26, 2025

Uh oh!

bors commented May 26, 2025

Uh oh!

Uh oh!

Rollup of 9 pull requests #141561

Rollup of 9 pull requests #141561

Uh oh!

Conversation

jhpratt commented May 25, 2025 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jhpratt commented May 25, 2025

Uh oh!

bors commented May 25, 2025

Uh oh!

bors commented May 26, 2025

Uh oh!

rust-log-analyzer commented May 26, 2025

Uh oh!

bors commented May 26, 2025

Uh oh!

Uh oh!

jhpratt commented May 25, 2025 •

edited by rustbot

Loading