std: sys: net: uefi: tcp4: Implement write #141532
Open
+51
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A blocking implementation of tcp4 write. Signed-off-by: Ayush Singh <[email protected]>
rustbot
added
S-waiting-on-review
|
@rustbot label +O-UEFI |
tgross35
reviewed
Jul 1, 2025
There was a problem hiding this comment.
A few nits but this looks reasonable to me. @nicholasbishop would you mind double checking since this is UEFI?
| let protocol = self.protocol.as_ptr(); | ||
| let mut token = tcp4::IoToken { | ||
| completion_token, | ||
| packet: tcp4::IoTokenPacket { tx_data: &mut tx_data as *mut _ as *mut _ }, |
There was a problem hiding this comment.
packet: tcp4::IoTokenPacket { tx_data: ptr::from_mut(&mut tx_data).cast::<whatever>() },What casts are needed? tx_data should be tcp4::TransmitData, and that looks like what is expected in https://docs.rs/r-efi/latest/r_efi/protocols/tcp4/union.IoTokenPacket.html.
Also, isn't rx_data missing?
|
|
||
| let fragment = tcp4::FragmentData { | ||
| fragment_length: data_len, | ||
| fragment_buffer: buf.as_ptr() as *mut _, |
There was a problem hiding this comment.
Nit to make the cast obvious (especially since it includes a mutability change)
fragment_buffer: buf.as_ptr().cast::<c_void>().cast_mut()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A blocking implementation of tcp4 write.