Skip to content

Conversation

nnethercote
Copy link
Contributor

Some minor cleanups I made when reading this code.

r? @Nadrieril

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels May 20, 2025
@compiler-errors
Copy link
Member

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented May 20, 2025

📌 Commit 8a927e6 has been approved by compiler-errors

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 20, 2025
bors added a commit to rust-lang-ci/rust that referenced this pull request May 20, 2025
…iaskrgr

Rollup of 7 pull requests

Successful merges:

 - rust-lang#139419 (Error on recursive opaque ty in HIR typeck)
 - rust-lang#141236 (Resolved issue with mismatched types triggering ICE in certain scenarios)
 - rust-lang#141253 (Warning added when dependency crate has async drop types, and the feature is disabled)
 - rust-lang#141269 (rustc-dev-guide subtree update)
 - rust-lang#141275 (`gather_locals`: only visit guard pattern guards when checking the guard)
 - rust-lang#141279 (`lower_to_hir` cleanups)
 - rust-lang#141285 (Add tick to `RePlaceholder` debug output)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 3b9ccbb into rust-lang:master May 20, 2025
6 checks passed
@rustbot rustbot added this to the 1.89.0 milestone May 20, 2025
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request May 20, 2025
Rollup merge of rust-lang#141279 - nnethercote:lower_to_hir, r=compiler-errors

`lower_to_hir` cleanups

Some minor cleanups I made when reading this code.

r? `@Nadrieril`
@nnethercote nnethercote deleted the lower_to_hir branch May 21, 2025 01:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants