Skip to content

Conversation

Darksonn
Copy link
Contributor

@Darksonn Darksonn commented May 7, 2025

cc @ojeda

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels May 7, 2025
@bjorn3
Copy link
Member

bjorn3 commented May 7, 2025

What exactly does Linux need this for?

@Darksonn
Copy link
Contributor Author

Darksonn commented May 7, 2025

I will add more info to the PR description before removing the draft marker, but for now please see #116852 (comment) and the original clang change.

@ojeda
Copy link
Contributor

ojeda commented May 7, 2025

I was looking into this last week and I think this needs a few more things, and should probably go into (or on top of) @azhogin's #135927, since that allows us to test it properly (and I think it does not make much sense without it?).

I sent a draft PR at #140740 -- please feel free to take the commit into your PR @azhogin. (I rebased @azhogin's there, and I added a Co-developed-by because I wasn't sure how to split it).

It additionally contains the assembly test for call and jmp, the docs and the invalid flag test.

@ojeda
Copy link
Contributor

ojeda commented May 7, 2025

I have kept the commit from here just in case and to show the difference/additions.

@ojeda
Copy link
Contributor

ojeda commented May 7, 2025

@rustbot label F-target_modifiers A-rust-for-linux

@rustbot rustbot added A-rust-for-linux Relevant for the Rust-for-Linux project F-target_modifiers `#![feature(target_modifiers)]` labels May 7, 2025
@Darksonn
Copy link
Contributor Author

Closing in favor of #140740.

@Darksonn Darksonn closed this Jul 20, 2025
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 20, 2025
@Darksonn Darksonn deleted the indirect-branch-cs-prefix branch August 22, 2025 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-rust-for-linux Relevant for the Rust-for-Linux project F-target_modifiers `#![feature(target_modifiers)]` T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants