std::net: update tcp deferaccept delay type to Duration. #140482

devnexen · 2025-04-29T18:03:19Z

See comment here.

rustbot · 2025-04-29T18:03:24Z

rustbot has assigned @ibraheemdev.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

ibraheemdev · 2025-05-02T02:34:53Z

r? libs for the (unstable) API change.

thomcc · 2025-05-30T11:32:05Z

r? libs-api

library/std/src/sys/net/connection/socket/unix.rs

rustbot · 2025-08-30T05:32:45Z

This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

library/std/src/sys/net/connection/socket/unix.rs

library/std/src/os/net/linux_ext/tcp.rs

joboet

Apart from the nit the implementation looks good to me. I'm nominating this for libs-api to discuss the overflow behaviour. It might arguably be better to use a saturating conversion on the seconds – deferring the ACK for less time than given is not really an error.

@rustbot label +I-libs-api-nominated

View changes since this review

library/std/src/sys/net/connection/socket/unix.rs

Amanieu · 2025-09-17T01:13:39Z

library/std/src/os/net/linux_ext/tcp.rs

-    fn set_deferaccept(&self, accept: u32) -> io::Result<()>;
+    fn set_deferaccept(&self, accept: Duration) -> io::Result<()>;

    /// Gets the accept delay value (in seconds) of the `TCP_DEFER_ACCEPT` option.


Suggested change

/// Gets the accept delay value (in seconds) of the `TCP_DEFER_ACCEPT` option.

/// Gets the accept delay value of the `TCP_DEFER_ACCEPT` option.

joboet · 2025-09-25T15:40:44Z

library/std/src/os/net/linux_ext/tcp.rs

+    /// Note that the delay is expressed as Duration from user's perspective
+    /// the call rounds it down to the nearest second.


This is misleading, the "nearest second" might very well be quite a lot smaller than the duration.

how would you phrase it ?

I'd probably just remove the sentence. Alternatively,

Suggested change

/// Note that the delay is expressed as Duration from user's perspective

/// the call rounds it down to the nearest second.

the call rounds it down to the nearest second expressible as a [`c_int`].

joboet · 2025-09-26T19:40:22Z

Great, thank you!
@bors r+

bors · 2025-09-26T19:40:25Z

📌 Commit c0de794 has been approved by joboet

It is now in the queue for this repository.

…n, r=joboet std::net: update tcp deferaccept delay type to Duration. See comment [here](rust-lang#119639 (comment)).

Rollup of 9 pull requests Successful merges: - #140482 (std::net: update tcp deferaccept delay type to Duration.) - #146037 (Introduce CoerceShared lang item and trait, and basic Reborrow tests) - #146732 (tests: relax expectations after llvm change 902ddda120a5) - #147018 (re-order normalizations in run-make linker-warning test) - #147032 (Fix doctest compilation time display) - #147046 (Rename `rust.use-lld` to `rust.bootstrap-override-lld`) - #147050 (PassWrapper: update for new PGOOptions args in LLVM 22) - #147075 (Make `def_path_hash_to_def_id` not panic when passed an invalid hash) - #147076 (update issue number for more_float_constants) r? `@ghost` `@rustbot` modify labels: rollup

matthiaskrgr · 2025-09-27T19:27:57Z

@bors r-
#147087 (comment)

devnexen · 2025-09-27T19:39:59Z

@rustbot ready

joboet · 2025-09-28T16:02:44Z

@bors r+

bors · 2025-09-28T16:02:46Z

📌 Commit 19d0e72 has been approved by joboet

It is now in the queue for this repository.

…n, r=joboet std::net: update tcp deferaccept delay type to Duration. See comment [here](rust-lang#119639 (comment)).

Rollup of 6 pull requests Successful merges: - #140482 (std::net: update tcp deferaccept delay type to Duration.) - #141469 (Allow `&raw [mut | const]` for union field in safe code) - #144197 (TypeTree support in autodiff) - #146675 (Allow shared access to `Exclusive<T>` when `T: Sync`) - #147113 (Reland "Add LSX accelerated implementation for source file analysis") - #147120 (Fix --extra-checks=spellcheck to prevent cargo install every time) r? `@ghost` `@rustbot` modify labels: rollup

rustbot assigned ibraheemdev Apr 29, 2025

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Apr 29, 2025

This comment has been minimized.

Sign in to view

devnexen force-pushed the tcp_deferaccept_toduration branch from b1c90c8 to 82a0b2a Compare April 29, 2025 18:28

This comment has been minimized.

Sign in to view

devnexen force-pushed the tcp_deferaccept_toduration branch from 82a0b2a to 7a84725 Compare April 29, 2025 19:00

This comment has been minimized.

Sign in to view

devnexen force-pushed the tcp_deferaccept_toduration branch from 7a84725 to 7cea902 Compare April 29, 2025 19:29

rustbot assigned thomcc and unassigned ibraheemdev May 2, 2025

rustbot added the T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. label May 30, 2025

rustbot assigned joshtriplett and unassigned thomcc May 30, 2025

joboet reviewed Aug 29, 2025

View reviewed changes

library/std/src/sys/net/connection/socket/unix.rs Outdated Show resolved Hide resolved

joboet reviewed Aug 29, 2025

View reviewed changes

library/std/src/sys/net/connection/socket/unix.rs Outdated Show resolved Hide resolved

devnexen force-pushed the tcp_deferaccept_toduration branch from 7cea902 to dafdcfa Compare August 30, 2025 05:32

devnexen requested a review from joboet August 30, 2025 06:49

joboet reviewed Aug 30, 2025

View reviewed changes

library/std/src/sys/net/connection/socket/unix.rs Outdated Show resolved Hide resolved

joboet assigned joboet and unassigned joshtriplett Aug 30, 2025

joboet reviewed Aug 30, 2025

View reviewed changes

library/std/src/os/net/linux_ext/tcp.rs Outdated Show resolved Hide resolved

devnexen force-pushed the tcp_deferaccept_toduration branch from dafdcfa to c0c9afe Compare August 30, 2025 08:34

joboet reviewed Aug 30, 2025

View reviewed changes

library/std/src/sys/net/connection/socket/unix.rs Outdated Show resolved Hide resolved

rustbot added the I-libs-api-nominated Nominated for discussion during a libs-api team meeting. label Aug 30, 2025

devnexen force-pushed the tcp_deferaccept_toduration branch from c0c9afe to a1096c6 Compare August 30, 2025 10:30

rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 16, 2025

Amanieu reviewed Sep 17, 2025

View reviewed changes

devnexen force-pushed the tcp_deferaccept_toduration branch from 13f8c1d to 05fecb3 Compare September 17, 2025 05:27

joboet reviewed Sep 25, 2025

View reviewed changes

devnexen force-pushed the tcp_deferaccept_toduration branch from 05fecb3 to c414a42 Compare September 26, 2025 16:50

This comment has been minimized.

Sign in to view

std::net: update tcp deferaccept delay type to Duration.

c0de794

devnexen force-pushed the tcp_deferaccept_toduration branch from c414a42 to c0de794 Compare September 26, 2025 17:39

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 26, 2025

GuillaumeGomez mentioned this pull request Sep 27, 2025

Rollup of 9 pull requests #147087

Closed

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 27, 2025

fix build for android

19d0e72

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 27, 2025

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 28, 2025

matthiaskrgr mentioned this pull request Sep 28, 2025

Rollup of 6 pull requests #147128

Open

	/// Gets the accept delay value (in seconds) of the `TCP_DEFER_ACCEPT` option.
	/// Gets the accept delay value of the `TCP_DEFER_ACCEPT` option.

		/// Note that the delay is expressed as Duration from user's perspective
		/// the call rounds it down to the nearest second.

	/// Note that the delay is expressed as Duration from user's perspective
	/// the call rounds it down to the nearest second.
	the call rounds it down to the nearest second expressible as a [`c_int`].

std::net: update tcp deferaccept delay type to Duration. #140482

Are you sure you want to change the base?

std::net: update tcp deferaccept delay type to Duration. #140482

Uh oh!

Conversation

devnexen commented Apr 29, 2025

Uh oh!

rustbot commented Apr 29, 2025

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

ibraheemdev commented May 2, 2025

Uh oh!

thomcc commented May 30, 2025

Uh oh!

Uh oh!

Uh oh!

rustbot commented Aug 30, 2025

Uh oh!

Uh oh!

Uh oh!

joboet left a comment • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Amanieu Sep 17, 2025

Choose a reason for hiding this comment

Uh oh!

joboet Sep 25, 2025

Choose a reason for hiding this comment

Uh oh!

devnexen Sep 26, 2025

Choose a reason for hiding this comment

Uh oh!

joboet Sep 26, 2025

Choose a reason for hiding this comment

Uh oh!

This comment has been minimized.

joboet commented Sep 26, 2025

Uh oh!

bors commented Sep 26, 2025

Uh oh!

matthiaskrgr commented Sep 27, 2025

Uh oh!

devnexen commented Sep 27, 2025

Uh oh!

joboet commented Sep 28, 2025

Uh oh!

bors commented Sep 28, 2025

Uh oh!

Uh oh!

joboet left a comment •

edited by rustbot

Loading