Skip to content

Fix auto diff failing on inherent impl blocks #140104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 23, 2025
Merged

Fix auto diff failing on inherent impl blocks #140104

merged 3 commits into from
Apr 23, 2025

Conversation

Shourya742
Copy link
Contributor

closes: #139557

r? @ZuseZ4

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Apr 21, 2025
@rustbot
Copy link
Collaborator

rustbot commented Apr 21, 2025

Some changes occurred in compiler/rustc_builtin_macros/src/autodiff.rs

cc @ZuseZ4

@Shourya742 Shourya742 changed the title 2025 04 21 auto diff fails on impl block auto diff fails on impl block Apr 21, 2025
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@fmease fmease changed the title auto diff fails on impl block Fix auto diff failing on inherent impl blocks Apr 21, 2025
@Shourya742 Shourya742 force-pushed the 2025-04-21-auto-diff-fails-on-impl-block branch from c4cbe4f to 11bd84e Compare April 21, 2025 12:04
@ZuseZ4
Copy link
Member

ZuseZ4 commented Apr 21, 2025

Now that we have 3 different pretty tests, can you please create a folder and move them all into tests/pretty/autodiff , to make it easier to run them?
Also, can you please rename the test to something more meaningful, like inherent_impl.rs?
Otherwise lgtm.

@ZuseZ4 ZuseZ4 added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 22, 2025
@Shourya742 Shourya742 force-pushed the 2025-04-21-auto-diff-fails-on-impl-block branch from 11bd84e to b8ca007 Compare April 22, 2025 04:28
@Shourya742
Copy link
Contributor Author

Now that we have 3 different pretty tests, can you please create a folder and move them all into tests/pretty/autodiff , to make it easier to run them? Also, can you please rename the test to something more meaningful, like inherent_impl.rs? Otherwise lgtm.

Added: b8ca007

@Shourya742
Copy link
Contributor Author

@rustbot review

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Apr 22, 2025
@ZuseZ4
Copy link
Member

ZuseZ4 commented Apr 22, 2025

Yep, it passes all tests locally, thanks!
@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Apr 22, 2025

📌 Commit b8ca007 has been approved by ZuseZ4

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 22, 2025
ChrisDenton added a commit to ChrisDenton/rust that referenced this pull request Apr 22, 2025
@ChrisDenton
Rollup merge of rust-lang#140104 - Shourya742:2025-04-21-auto-diff-fa…
a7b44e2 
…ils-on-impl-block, r=ZuseZ4

Fix auto diff failing on inherent impl blocks

closes: rust-lang#139557

r? `@ZuseZ4`
@ChrisDenton ChrisDenton mentioned this pull request Apr 22, 2025
Closed
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 22, 2025
@bors
Auto merge of rust-lang#140161 - ChrisDenton:rollup-krbf3er, r=ChrisD…
6d35f2a 
…enton

Rollup of 8 pull requests

Successful merges:

 - rust-lang#139309 (make abi_unsupported_vector_types a hard error)
 - rust-lang#139617 (Use posix_spawn on cygwin)
 - rust-lang#140072 (handle function alignment in miri)
 - rust-lang#140104 (Fix auto diff failing on inherent impl blocks)
 - rust-lang#140124 (Update books)
 - rust-lang#140144 (Handle another negated literal in `eat_token_lit`.)
 - rust-lang#140146 (Update `compiler_builtins` to 0.1.156)
 - rust-lang#140149 (test_nan: ensure the NAN contant is quiet)

r? `@ghost`
`@rustbot` modify labels: rollup
@ChrisDenton ChrisDenton mentioned this pull request Apr 22, 2025
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 22, 2025
@bors
Auto merge of rust-lang#140165 - ChrisDenton:rollup-on2dpr5, r=ChrisD…
6a3a8b8 
…enton

Rollup of 8 pull requests

Successful merges:

 - rust-lang#139617 (Use posix_spawn on cygwin)
 - rust-lang#139921 (improve diagnostic for raw pointer field access with ->)
 - rust-lang#140031 (compiletest: Fix deadline bugs in new executor)
 - rust-lang#140072 (handle function alignment in miri)
 - rust-lang#140104 (Fix auto diff failing on inherent impl blocks)
 - rust-lang#140124 (Update books)
 - rust-lang#140144 (Handle another negated literal in `eat_token_lit`.)
 - rust-lang#140149 (test_nan: ensure the NAN contant is quiet)

r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 22, 2025
@bors
Auto merge of rust-lang#140165 - ChrisDenton:rollup-on2dpr5, r=ChrisD…
1a5bf12 
…enton

Rollup of 8 pull requests

Successful merges:

 - rust-lang#139617 (Use posix_spawn on cygwin)
 - rust-lang#139921 (improve diagnostic for raw pointer field access with ->)
 - rust-lang#140031 (compiletest: Fix deadline bugs in new executor)
 - rust-lang#140072 (handle function alignment in miri)
 - rust-lang#140104 (Fix auto diff failing on inherent impl blocks)
 - rust-lang#140124 (Update books)
 - rust-lang#140144 (Handle another negated literal in `eat_token_lit`.)
 - rust-lang#140149 (test_nan: ensure the NAN contant is quiet)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 264249f into rust-lang:master Apr 23, 2025
6 checks passed
@rustbot rustbot added this to the 1.88.0 milestone Apr 23, 2025
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Apr 23, 2025
@rust-timer
Unrolled build for rust-lang#140104
9fca163 
Rollup merge of rust-lang#140104 - Shourya742:2025-04-21-auto-diff-fails-on-impl-block, r=ZuseZ4

Fix auto diff failing on inherent impl blocks

closes: rust-lang#139557

r? ``@ZuseZ4``
@ZuseZ4 ZuseZ4 mentioned this pull request May 25, 2025
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ZuseZ4 ZuseZ4

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.88.0
Development

Successfully merging this pull request may close these issues.

autodiff fails in impl blocks
5 participants
@Shourya742 @rustbot @rust-log-analyzer @ZuseZ4 @bors