Skip to content

Conversation

thaliaarchi
Copy link
Contributor

@thaliaarchi thaliaarchi commented Apr 20, 2025

This is trivial and has no design questions.

Tracked in #133333.

r? libs-api

@rustbot
Copy link
Collaborator

rustbot commented Apr 20, 2025

r? @ibraheemdev

rustbot has assigned @ibraheemdev.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Apr 20, 2025
@rustbot rustbot added the T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. label Apr 20, 2025
@rustbot rustbot assigned BurntSushi and unassigned ibraheemdev Apr 20, 2025
@jhpratt
Copy link
Member

jhpratt commented Apr 21, 2025

r? jhpratt

r=me with completed FCP

@rustbot rustbot assigned jhpratt and unassigned BurntSushi Apr 21, 2025
@BurntSushi

This comment was marked as outdated.

@rfcbot

This comment was marked as outdated.

@rfcbot rfcbot added proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. labels Apr 21, 2025
@BurntSushi

This comment was marked as outdated.

@rfcbot

This comment was marked as outdated.

@rfcbot rfcbot removed proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. labels Apr 21, 2025
@BurntSushi BurntSushi removed the T-libs Relevant to the library team, which will review and decide on the PR/issue. label Apr 21, 2025
@BurntSushi
Copy link
Member

@rfcbot fcp merge

@rfcbot
Copy link

rfcbot commented Apr 21, 2025

Team member @BurntSushi has proposed to merge this. The next step is review by the rest of the tagged team members:

No concerns currently listed.

Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

@rfcbot rfcbot added proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. and removed proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. labels Apr 21, 2025
@rfcbot
Copy link

rfcbot commented Apr 21, 2025

🔔 This is now entering its final comment period, as per the review above. 🔔

@rfcbot rfcbot added finished-final-comment-period The final comment period is finished for this PR / Issue. and removed final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. labels May 1, 2025
@rfcbot
Copy link

rfcbot commented May 1, 2025

The final comment period, with a disposition to merge, as per the review above, is now complete.

As the automated representative of the governance process, I would like to thank the author for their work and everyone else who contributed.

This will be merged soon.

@jhpratt
Copy link
Member

jhpratt commented May 24, 2025

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented May 24, 2025

📌 Commit 38c5545 has been approved by jhpratt

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 24, 2025
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request May 24, 2025
…ce, r=jhpratt

Stabilize `<[T; N]>::as_mut_slice` as `const`

This is trivial and has no design questions.

Tracked in rust-lang#133333.

r? libs-api
jhpratt added a commit to jhpratt/rust that referenced this pull request May 24, 2025
…ce, r=jhpratt

Stabilize `<[T; N]>::as_mut_slice` as `const`

This is trivial and has no design questions.

Tracked in rust-lang#133333.

r? libs-api
bors added a commit that referenced this pull request May 24, 2025
Rollup of 6 pull requests

Successful merges:

 - #140066 (Stabilize `<[T; N]>::as_mut_slice` as `const`)
 - #141105 (additional edge cases tests for `path.rs` 🧪 )
 - #141487 (Update askama to `0.14.0`)
 - #141498 (Use C-string literals to reduce boilerplate)
 - #141505 (rename internal panicking::try to catch_unwind)
 - #141511 (Cleanup CodegenFnAttrFlags)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 07157b7 into rust-lang:master May 25, 2025
6 checks passed
@rustbot rustbot added this to the 1.89.0 milestone May 25, 2025
rust-timer added a commit that referenced this pull request May 25, 2025
Rollup merge of #140066 - thaliaarchi:const-array-as-mut-slice, r=jhpratt

Stabilize `<[T; N]>::as_mut_slice` as `const`

This is trivial and has no design questions.

Tracked in #133333.

r? libs-api
github-actions bot pushed a commit to rust-lang/miri that referenced this pull request May 25, 2025
Rollup of 6 pull requests

Successful merges:

 - rust-lang/rust#140066 (Stabilize `<[T; N]>::as_mut_slice` as `const`)
 - rust-lang/rust#141105 (additional edge cases tests for `path.rs` 🧪 )
 - rust-lang/rust#141487 (Update askama to `0.14.0`)
 - rust-lang/rust#141498 (Use C-string literals to reduce boilerplate)
 - rust-lang/rust#141505 (rename internal panicking::try to catch_unwind)
 - rust-lang/rust#141511 (Cleanup CodegenFnAttrFlags)

r? `@ghost`
`@rustbot` modify labels: rollup
github-actions bot pushed a commit to model-checking/verify-rust-std that referenced this pull request May 26, 2025
…ce, r=jhpratt

Stabilize `<[T; N]>::as_mut_slice` as `const`

This is trivial and has no design questions.

Tracked in rust-lang#133333.

r? libs-api
@apiraino apiraino removed the to-announce Announce this issue on triage meeting label Jun 5, 2025
@cuviper cuviper added the relnotes Marks issues that should be documented in the release notes of the next release. label Jul 17, 2025
@thaliaarchi thaliaarchi deleted the const-array-as-mut-slice branch September 17, 2025 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. finished-final-comment-period The final comment period is finished for this PR / Issue. relnotes Marks issues that should be documented in the release notes of the next release. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants