Remove `Symbol` from `Named` variant of `BoundRegionKind`/`LateParamRegionKind` #139598

compiler-errors · 2025-04-09T20:05:03Z

The Symbol is redundant, since we already store a DefId in the region variant. Instead, load the name via item_name when needed (which is almost always on the diagnostic path).

This introduces a BoundRegionKind::NamedAnon which is used for giving anonymous bound regions names, but which should only be used during pretty printing and error reporting.

compiler-errors · 2025-04-09T20:05:09Z

@bors try @rust-timer queue

… r=<try> Remove `Symbol` from `Named` variant of `BoundRegionKind`/`LateParamRegionKind` r? `@ghost`

bors · 2025-04-09T20:06:22Z

⌛ Trying commit dba712a with merge 098a24f...

bors · 2025-04-09T22:04:09Z

☀️ Try build successful - checks-actions
Build commit: 098a24f (098a24f333aac968a2fcbf1e3d152550224ea44d)

rust-timer · 2025-04-10T04:42:34Z

Finished benchmarking commit (098a24f): comparison URL.

Overall result: ❌✅ regressions and improvements - please read the text below

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

This is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.

	mean	range	count
Regressions ❌ (primary)	0.2%	[0.1%, 0.3%]	4
Regressions ❌ (secondary)	0.3%	[0.2%, 0.4%]	12
Improvements ✅ (primary)	-0.2%	[-0.5%, -0.1%]	54
Improvements ✅ (secondary)	-0.3%	[-0.6%, -0.1%]	37
All ❌✅ (primary)	-0.2%	[-0.5%, 0.3%]	58

Max RSS (memory usage)

Results (primary -0.4%, secondary -0.4%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	2.2%	[0.9%, 3.5%]	2
Regressions ❌ (secondary)	3.4%	[1.8%, 4.6%]	3
Improvements ✅ (primary)	-2.1%	[-2.6%, -1.5%]	3
Improvements ✅ (secondary)	-3.3%	[-3.9%, -2.1%]	4
All ❌✅ (primary)	-0.4%	[-2.6%, 3.5%]	5

Cycles

Results (primary 0.6%, secondary 1.4%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	1.3%	[1.0%, 1.6%]	3
Regressions ❌ (secondary)	1.4%	[1.4%, 1.4%]	1
Improvements ✅ (primary)	-1.4%	[-1.4%, -1.4%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.6%	[-1.4%, 1.6%]	4

Binary size

Results (primary -0.1%, secondary -0.2%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.1%	[-0.3%, -0.0%]	118
Improvements ✅ (secondary)	-0.2%	[-0.8%, -0.0%]	33
All ❌✅ (primary)	-0.1%	[-0.3%, -0.0%]	118

Bootstrap: 780.203s -> 780.55s (0.04%)
Artifact size: 366.14 MiB -> 366.17 MiB (0.01%)

bors · 2025-05-06T02:29:41Z

☔ The latest upstream changes (presumably #140682) made this pull request unmergeable. Please resolve the merge conflicts.

compiler-errors · 2025-06-25T17:56:36Z

This is ready to review I think.

rustbot · 2025-06-25T17:56:40Z

r? @WaffleLapkin

rustbot has assigned @WaffleLapkin.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

rustbot · 2025-06-25T17:56:41Z

HIR ty lowering was modified

cc @fmease

compiler-errors · 2025-06-25T18:01:05Z

@rustbot author

bors · 2025-06-27T01:16:44Z

☔ The latest upstream changes (presumably #143057) made this pull request unmergeable. Please resolve the merge conflicts.

compiler-errors · 2025-06-27T19:09:22Z

naur

@rustbot ready

bors · 2025-06-27T19:55:10Z

☔ The latest upstream changes (presumably #143091) made this pull request unmergeable. Please resolve the merge conflicts.

WaffleLapkin

r=me with/out nits

compiler/rustc_hir_analysis/src/collect.rs

compiler/rustc_middle/src/ty/region.rs

...ler/rustc_trait_selection/src/error_reporting/infer/nice_region_error/named_anon_conflict.rs

compiler-errors · 2025-07-05T05:24:13Z

@bors r+ p=1 (bitrotty)

bors · 2025-07-05T05:24:16Z

📌 Commit dc8cac8 has been approved by compiler-errors

It is now in the queue for this repository.

compiler-errors · 2025-07-05T05:25:06Z

oops

@bors r=WaffleLapkin

bors · 2025-07-05T05:25:08Z

💡 This pull request was already approved, no need to approve it again.

There's another pull request that is currently being tested, blocking this pull request: Update the compiler-builtins subtree #143405

bors · 2025-07-05T05:25:09Z

📌 Commit dc8cac8 has been approved by WaffleLapkin

It is now in the queue for this repository.

bors · 2025-07-05T06:29:59Z

⌛ Testing commit dc8cac8 with merge f0b67dd...

bors · 2025-07-05T09:36:01Z

☀️ Test successful - checks-actions
Approved by: WaffleLapkin
Pushing f0b67dd to master...

github-actions · 2025-07-05T09:39:02Z

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 733b47e (parent) -> f0b67dd (this PR)

Test differences

Show 6 test diffs

6 doctest diffs were found. These are ignored, as they are noisy.

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard f0b67dd97d74610ee4185cf01c775a563c2017a2 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

dist-aarch64-linux: 5753.6s -> 8475.1s (47.3%)
x86_64-apple-1: 9878.0s -> 6584.6s (-33.3%)
aarch64-apple: 4637.2s -> 5254.6s (13.3%)
dist-x86_64-apple: 8273.4s -> 7246.5s (-12.4%)
x86_64-apple-2: 5589.6s -> 4942.2s (-11.6%)
dist-aarch64-apple: 5354.4s -> 4806.6s (-10.2%)
dist-sparcv9-solaris: 4750.3s -> 5049.8s (6.3%)
x86_64-gnu-tools: 3776.3s -> 3562.3s (-5.7%)
dist-loongarch64-linux: 5995.4s -> 5685.2s (-5.2%)
test-various: 4914.0s -> 4684.9s (-4.7%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

rust-timer · 2025-07-05T10:46:46Z

Finished benchmarking commit (f0b67dd): comparison URL.

Overall result: ❌✅ regressions and improvements - please read the text below

Our benchmarks found a performance regression caused by this PR.
This might be an actual regression, but it can also be just noise.

Next Steps:

If the regression was expected or you think it can be justified,
please write a comment with sufficient written justification, and add
@rustbot label: +perf-regression-triaged to it, to mark the regression as triaged.
If you think that you know of a way to resolve the regression, try to create
a new PR with a fix for the regression.
If you do not understand the regression or you think that it is just noise,
you can ask the @rust-lang/wg-compiler-performance working group for help (members of this group
were already notified of this PR).

@rustbot label: +perf-regression
cc @rust-lang/wg-compiler-performance

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	0.5%	[0.1%, 3.2%]	13
Regressions ❌ (secondary)	0.4%	[0.1%, 0.6%]	23
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-0.4%	[-0.5%, -0.1%]	7
All ❌✅ (primary)	0.5%	[0.1%, 3.2%]	13

Max RSS (memory usage)

Results (primary 0.9%, secondary 2.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	2.9%	[2.3%, 3.8%]	3
Regressions ❌ (secondary)	4.0%	[2.7%, 5.0%]	4
Improvements ✅ (primary)	-2.0%	[-2.3%, -1.8%]	2
Improvements ✅ (secondary)	-1.8%	[-1.8%, -1.7%]	2
All ❌✅ (primary)	0.9%	[-2.3%, 3.8%]	5

Cycles

Results (primary -2.4%, secondary -0.5%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.2%	[0.5%, 3.5%]	3
Improvements ✅ (primary)	-2.4%	[-2.4%, -2.4%]	1
Improvements ✅ (secondary)	-3.3%	[-5.4%, -0.5%]	3
All ❌✅ (primary)	-2.4%	[-2.4%, -2.4%]	1

Binary size

Results (primary -0.1%, secondary -0.2%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	1.1%	[1.1%, 1.1%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.1%	[-0.3%, -0.0%]	96
Improvements ✅ (secondary)	-0.2%	[-0.8%, -0.0%]	50
All ❌✅ (primary)	-0.1%	[-0.3%, 1.1%]	97

Bootstrap: 461.743s -> 460.935s (-0.17%)
Artifact size: 372.21 MiB -> 372.19 MiB (-0.01%)

compiler-errors · 2025-07-05T17:29:55Z

The clap derive regression looks unrelated b/c it seems to be bimodal +/-3%.

Rest of the regressions are 🤷, kind of a shame that this ended up not actually benefitting perf, but I don't know what changed in this PR's impl that would have nullified the previous results.

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Apr 9, 2025

This comment has been minimized.

Sign in to view

rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Apr 9, 2025

bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 9, 2025

Auto merge of rust-lang#139598 - compiler-errors:no-bound-var-symbol,…

098a24f

… r=<try> Remove `Symbol` from `Named` variant of `BoundRegionKind`/`LateParamRegionKind` r? `@ghost`

This comment has been minimized.

Sign in to view

rustbot added perf-regression Performance regression. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels Apr 10, 2025

compiler-errors force-pushed the no-bound-var-symbol branch from dba712a to b749895 Compare April 11, 2025 04:26

rustbot added the WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver) label Apr 11, 2025

This comment has been minimized.

Sign in to view

compiler-errors force-pushed the no-bound-var-symbol branch from b749895 to 20eebb2 Compare June 25, 2025 17:07

compiler-errors marked this pull request as ready for review June 25, 2025 17:56

rustbot assigned WaffleLapkin Jun 25, 2025

This comment has been minimized.

Sign in to view

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 25, 2025

compiler-errors force-pushed the no-bound-var-symbol branch from 20eebb2 to 69c5275 Compare June 25, 2025 22:32

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 27, 2025

WaffleLapkin approved these changes Jul 2, 2025

View reviewed changes

compiler/rustc_hir_analysis/src/collect.rs Outdated Show resolved Hide resolved

compiler/rustc_middle/src/ty/region.rs Outdated Show resolved Hide resolved

...ler/rustc_trait_selection/src/error_reporting/infer/nice_region_error/named_anon_conflict.rs Outdated Show resolved Hide resolved

WaffleLapkin added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 2, 2025

Remove Symbol for Named LateParam/Bound variants

42c9bfd

compiler-errors force-pushed the no-bound-var-symbol branch from 43b2648 to 9d1d3c2 Compare July 4, 2025 18:14

This comment has been minimized.

Sign in to view

compiler-errors added 4 commits July 4, 2025 18:26

Same for types

74570e5

Fix pretty printing of placeholder types

d79b669

Fix elided lifetimes in rustdoc

0ad96c1

Nits

dc8cac8

compiler-errors force-pushed the no-bound-var-symbol branch from 9d1d3c2 to dc8cac8 Compare July 4, 2025 18:45

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 5, 2025

bors added the merged-by-bors This PR was explicitly merged by bors. label Jul 5, 2025

bors merged commit f0b67dd into rust-lang:master Jul 5, 2025
12 checks passed

rustbot added this to the 1.90.0 milestone Jul 5, 2025

Remove Symbol from Named variant of BoundRegionKind/LateParamRegionKind #139598

Remove Symbol from Named variant of BoundRegionKind/LateParamRegionKind #139598

Conversation

compiler-errors commented Apr 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

compiler-errors commented Apr 9, 2025

Uh oh!

This comment has been minimized.

bors commented Apr 9, 2025

Uh oh!

This comment has been minimized.

bors commented Apr 9, 2025

Uh oh!

This comment has been minimized.

rust-timer commented Apr 10, 2025

Overall result: ❌✅ regressions and improvements - please read the text below

Uh oh!

This comment has been minimized.

bors commented May 6, 2025

Uh oh!

compiler-errors commented Jun 25, 2025

Uh oh!

rustbot commented Jun 25, 2025

Uh oh!

rustbot commented Jun 25, 2025

Uh oh!

This comment has been minimized.

compiler-errors commented Jun 25, 2025

Uh oh!

bors commented Jun 27, 2025

Uh oh!

compiler-errors commented Jun 27, 2025

Uh oh!

bors commented Jun 27, 2025

Uh oh!

WaffleLapkin left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

This comment has been minimized.

compiler-errors commented Jul 5, 2025

Uh oh!

bors commented Jul 5, 2025

Uh oh!

compiler-errors commented Jul 5, 2025

Uh oh!

bors commented Jul 5, 2025

Uh oh!

bors commented Jul 5, 2025

Uh oh!

bors commented Jul 5, 2025

Uh oh!

bors commented Jul 5, 2025

Uh oh!

Uh oh!

github-actions bot commented Jul 5, 2025

Test differences

Job duration changes

Uh oh!

rust-timer commented Jul 5, 2025

Overall result: ❌✅ regressions and improvements - please read the text below

Uh oh!

compiler-errors commented Jul 5, 2025

Uh oh!

Uh oh!

Remove `Symbol` from `Named` variant of `BoundRegionKind`/`LateParamRegionKind` #139598

Remove `Symbol` from `Named` variant of `BoundRegionKind`/`LateParamRegionKind` #139598

compiler-errors commented Apr 9, 2025 •

edited

Loading