Remove fragile equal-pointers-unequal/*/print3.rs tests. #139176
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @wesleywiser rustbot has assigned @wesleywiser. Use |
rustbot
added
S-waiting-on-review
|
I agree that these tests aren't really testing anything "useful", just monitoring specific manifestations of an underlying issue with pointers. @bors r+ rollup |
bors
added
S-waiting-on-bors
GrigorenkoPV
approved these changes
Mar 31, 2025
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Mar 31, 2025
Remove fragile equal-pointers-unequal/*/print3.rs tests. These tests were added in rust-lang#127003 The print3.rs tests stop working when I change implementation details of format_args!(). (For example, in rust-lang#139175 and rust-lang#139135). These tests shouldn't rely on such implementation details. It gets in the way for format_args!() improvements. If they test anything that aren't already covered by the other tests in this directory, they should be expressed in a less fragile way that doesn't rely on internal details of format_args!(). cc `@GrigorenkoPV,` author of these tests.
This was referenced Mar 31, 2025
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 1, 2025
…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#138426 (Fix `armv7-sony-vita-newlibeabihf` LLVM target triple) - rust-lang#138840 (rustc_resolve: Test the order that preludes are resolved) - rust-lang#139039 (Reduce kw::Empty usage, part 4) - rust-lang#139151 (tidy: properly check for orphaned unstable_book pages) - rust-lang#139176 (Remove fragile equal-pointers-unequal/*/print3.rs tests.) - rust-lang#139179 (Remove me from vacation) - rust-lang#139181 (Fix invalid link in docs) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 1, 2025
Rollup merge of rust-lang#139176 - m-ou-se:print3, r=compiler-errors Remove fragile equal-pointers-unequal/*/print3.rs tests. These tests were added in rust-lang#127003 The print3.rs tests stop working when I change implementation details of format_args!(). (For example, in rust-lang#139175 and rust-lang#139135). These tests shouldn't rely on such implementation details. It gets in the way for format_args!() improvements. If they test anything that aren't already covered by the other tests in this directory, they should be expressed in a less fragile way that doesn't rely on internal details of format_args!(). cc ``@GrigorenkoPV,`` author of these tests.
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
May 3, 2025
…errors Remove fragile equal-pointers-unequal tests. Same as rust-lang#139176 --- These tests were added in rust-lang#127003 These tests stop working when I change implementation details of format_args!(). These tests shouldn't rely on such implementation details. Do these tests test anything that isn't already covered by other tests? If so, they should be expressed in a less fragile way that doesn't rely on internal details of format_args!(). cc `@GrigorenkoPV,` author of these tests.
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 3, 2025
Rollup merge of rust-lang#140576 - m-ou-se:fragile-tests, r=compiler-errors Remove fragile equal-pointers-unequal tests. Same as rust-lang#139176 --- These tests were added in rust-lang#127003 These tests stop working when I change implementation details of format_args!(). These tests shouldn't rely on such implementation details. Do these tests test anything that isn't already covered by other tests? If so, they should be expressed in a less fragile way that doesn't rely on internal details of format_args!(). cc `@GrigorenkoPV,` author of these tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These tests were added in #127003
The print3.rs tests stop working when I change implementation details of format_args!(). (For example, in #139175 and #139135). These tests shouldn't rely on such implementation details. It gets in the way for format_args!() improvements.
If they test anything that aren't already covered by the other tests in this directory, they should be expressed in a less fragile way that doesn't rely on internal details of format_args!().
cc @GrigorenkoPV, author of these tests.