rustc_target: Sync with stdarch (important parts) #138820
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
a4lg
force-pushed
the
riscv-feature-addition-base-i-and-ztso
branch
2 times, most recently
from
e7f364c to
4a8cb94
Compare
This comment has been minimized.
This comment has been minimized.
|
Hmm, considering the minimum LLVM version, I have to remove |
Of RISC-V features defined in stdarch, this commit adds extensions
satisfying following criteria:
* Formerly a part of the "I" extension and splitted thereafter
(now ratified as "I" + "Zifencei" + "Zicsr" + "Zicntr" + "Zihpm") or
* Dicoverable from newer versions of the Linux kernel ("Zihintpause").
This is based on the latest ratified ISA Manuals (version 20240411).
One of those, "Zicsr", is a dependency of many other ISA extensions and
this commit adds correct dependencies to "Zicsr" except "V"
(due to an ongoing PR).
a4lg
force-pushed
the
riscv-feature-addition-base-i-and-ztso
branch
from
4a8cb94 to
1649e52
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Of RISC-V features defined in stdarch, this commit adds ratified extensions satisfying following criteria:
Iextension and splitted thereafter (now ratified asI+Zifencei+Zicsr+Zicntr+Zihpm) orZtsoandZihintpause).This is based on the latest ratified ISA Manuals (version 20240411).
LLVM Definitions:
ZifenceiZicsrZicntrZihpmZtsoZihintpauseOne of those,
Zicsr, is a dependency of many other ISA extensions and this commit adds correct dependencies toZicsrexceptV(due to ongoing PR #138742).Related:
#[target_feature]#44839(
riscv_target_feature)(This PR can be a prerequisite of resolving a part of that tracking issue)
(Touches the same place and vector extensions depend on
Zicsr)NOT Related but linked:
-Ctarget-features must be restrained on RISCV #132618(This PR won't be blocked by this issue since none of those extensions do not change the ABI)
@rustbot label +T-compiler +O-riscv +A-target-feature