Skip to content

Conversation

marcoieni
Copy link
Member

@marcoieni marcoieni commented Dec 10, 2024

@rustbot
Copy link
Collaborator

rustbot commented Dec 10, 2024

r? @Kobzol

rustbot has assigned @Kobzol.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Dec 10, 2024
@marcoieni
Copy link
Member Author

I expect the authentication to fail, let's see. Probably we need to add the permissions ecr-public:GetAuthorizationToken and sts:GetServiceBearerToken

@rust-log-analyzer

This comment has been minimized.

@Kobzol
Copy link
Member

Kobzol commented Dec 10, 2024

After the authentication works, we should also check whether it is still possible to build these Dockerfiles locally after these changes.

@marcoieni
Copy link
Member Author

It's possible, I tried, you are subject to the unauthenticated rate limit, as dockerhub. This is discussed in the linked issue 👍

@Kobzol
Copy link
Member

Kobzol commented Dec 10, 2024

I see, ok :) Awesome.

@rust-log-analyzer
Copy link
Collaborator

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)
info: removing cargo home
info: removing rustup binaries
info: rustup is uninstalled

usage: aws [options] <command> <subcommand> [<subcommand> ...] [parameters]
To see help text, you can run:
  aws help
  aws help
  aws <command> help
  aws <command> <subcommand> help
aws: error: the following arguments are required: value

##[error]Process completed with exit code 252.
Post job cleanup.

@marcoieni
Copy link
Member Author

it might be that since I'm in a fork we can't use the secret to authenticate with aws?

@bors
Copy link
Collaborator

bors commented Dec 19, 2024

☔ The latest upstream changes (presumably #133809) made this pull request unmergeable. Please resolve the merge conflicts.

@bors
Copy link
Collaborator

bors commented Dec 21, 2024

☔ The latest upstream changes (presumably #134614) made this pull request unmergeable. Please resolve the merge conflicts.

@marcoieni
Copy link
Member Author

we decided that ECR isn't a good fit.

@marcoieni marcoieni closed this Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Figure out docker hub caching
5 participants