Skip to content

Subtree update of rust-analyzer #133564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 27 commits into from
Nov 28, 2024
Merged

Subtree update of rust-analyzer #133564

merged 27 commits into from
Nov 28, 2024

Conversation

lnicola
Copy link
Member

@lnicola lnicola commented Nov 28, 2024

r? @ghost

Giga-Bowser and others added 26 commits November 1, 2024 12:35
@Giga-Bowser
Use snippet placeholders for generated match arms
3e3fd4a
@Giga-Bowser
Properly use final tabstop when adding missing match arms
bbfee60
@davidkurilla
feat: convert add_braces to SyntaxFactory SyntaxEditor abstraction
c588849
@davidkurilla
fix: fix immutable tree error
4216615
@davidkurilla
fix: fix indentation error
9085744
@davidkurilla
fix: remove unused imports
5458612
@davidkurilla
style: cargo fmt
34dd288
@davidkurilla
style: remove needless borrow
c627c1a
@tareknaser
feat: migrate reorder_impl_items assist to use SyntaxFactory
a96a093 
Signed-off-by: Tarek <[email protected]>
@darichey
Re-add rust-analyzer.cargo.sysrootQueryMetadata
b4a3168
@cmrschwarz
improve selection handling for merge_match_arms
effe9ac
@lnicola
Merge pull request rust-lang#18459 from Giga-Bowser/match-placeholders
00a8fc1 
feat: Use snippet placeholders for generated match arms
@lnicola
Merge pull request rust-lang#18529 from cmrschwarz/allow_leading_whit…
af318f7 
…espace_in_merge_match_arms

Improve selection handling for the `merge_match_arms` assist
@davidbarsky
Merge pull request rust-lang#18521 from tareknaser/syntax_factory_reo…
70a098e 
…rder_impl_items

Migrate `reorder_impl_items` Assist to Use `SyntaxFactory`
@davidbarsky
Merge pull request rust-lang#18485 from davidkurilla/feat-migrate-add…
297db65 
…_braces-to-use-SyntaxFactory

feat: convert add_braces to SyntaxFactory SyntaxEditor abstraction
@markmurphydev
Update request entry point file path in architecture.md
a3efe3b
@lnicola
Merge pull request rust-lang#18548 from markmurphydev/master
309c671 
Update file path for request.rs entry point in architecture.md
@lnicola
Fix missing rust-src message
63b82dd
@lnicola
Merge pull request rust-lang#18552 from lnicola/rust-src-message
b250e0f 
internal: Fix missing `rust-src` message
@ChayimFriedman2
Fix a stack overflow when computing the sizedness of a struct that in…
b4a23bb 
…cludes itself as the tail field
@lnicola
Merge pull request rust-lang#18559 from ChayimFriedman2/recur-unsized
bbce06e 
fix: Fix a stack overflow when computing the sizedness of a struct that includes itself as the tail field
@lnicola
Merge pull request rust-lang#18511 from darichey/sysroot-query-metadata
4e3354e 
Re-add `rust-analyzer.cargo.sysrootQueryMetadata`
@lnicola
Preparing for merge from rust-lang/rust
6e3cb4a
@lnicola
Merge from rust-lang/rust
c91f2a3
@lnicola
Bump rustc crates
1a435ed
@lnicola
Merge pull request rust-lang#18566 from lnicola/sync-from-rust
8cf30c2 
minor: Sync from downstream
@rustbot
Copy link
Collaborator

rustbot commented Nov 28, 2024

rust-analyzer is developed in its own repository. If possible, consider making this change to rust-lang/rust-analyzer instead.

cc @rust-lang/rust-analyzer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 28, 2024
@lnicola
Copy link
Member Author

lnicola commented Nov 28, 2024

@bors r+ p=1 subtree update

@bors
Copy link
Collaborator

bors commented Nov 28, 2024

📌 Commit 8cf30c2 has been approved by lnicola

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 28, 2024
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@lnicola
Copy link
Member Author

lnicola commented Nov 28, 2024

@bors r-

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Nov 28, 2024
@lnicola
Copy link
Member Author

lnicola commented Nov 28, 2024

@bors r+ p=1 subtree update

@bors
Copy link
Collaborator

bors commented Nov 28, 2024

📌 Commit 15e8a26 has been approved by lnicola

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 28, 2024
@bors
Copy link
Collaborator

bors commented Nov 28, 2024

⌛ Testing commit 15e8a26 with merge c1cfab2...

@bors
Copy link
Collaborator

bors commented Nov 28, 2024

☀️ Test successful - checks-actions
Approved by: lnicola
Pushing c1cfab2 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Nov 28, 2024
@bors bors merged commit c1cfab2 into rust-lang:master Nov 28, 2024
7 checks passed
@rustbot rustbot added this to the 1.85.0 milestone Nov 28, 2024
@lnicola lnicola deleted the sync-from-ra branch November 28, 2024 11:29
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (c1cfab2): comparison URL.

Overall result: ❌ regressions - no action needed

@rustbot label: -perf-regression

Instruction count

This is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 2.0% [2.0%, 2.0%] 1
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) - - 0

Max RSS (memory usage)

Results (primary 0.1%, secondary 2.7%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 3.2% [3.2%, 3.2%] 1
Regressions ❌
(secondary)		 2.7% [2.7%, 2.7%] 1
Improvements ✅
(primary)		 -3.0% [-3.0%, -3.0%] 1
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) 0.1% [-3.0%, 3.2%] 2

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 792.58s -> 793.251s (0.08%)
Artifact size: 335.88 MiB -> 335.84 MiB (-0.01%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.85.0
Development

Successfully merging this pull request may close these issues.