Skip to content

Conversation

compiler-errors
Copy link
Member

calm before the storm

@compiler-errors
Copy link
Member Author

r? lcnr

@rustbot
Copy link
Collaborator

rustbot commented Nov 22, 2024

r? @Nadrieril

rustbot has assigned @Nadrieril.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot assigned lcnr and unassigned Nadrieril Nov 22, 2024
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Nov 22, 2024
note: type must satisfy the static lifetime as required by this binding
--> $DIR/specialize_with_generalize_lifetimes.rs:12:15
|
LL | impl<T: Any + 'static> Tr for T {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not care about specialization enough to keep this span around.

@lcnr
Copy link
Contributor

lcnr commented Nov 22, 2024

r? @lcnr

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Nov 22, 2024

📌 Commit 357665d has been approved by lcnr

It is now in the queue for this repository.

bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 22, 2024
Rollup of 8 pull requests

Successful merges:

 - rust-lang#133238 (re-export `is_loongarch_feature_detected`)
 - rust-lang#133288 (Support `each_ref` and `each_mut` in `[T; N]` in constant expressions.)
 - rust-lang#133311 (Miri subtree update)
 - rust-lang#133313 (Use arc4random of libc for RTEMS target)
 - rust-lang#133319 (Simplify `fulfill_implication`)
 - rust-lang#133323 (Bail in effects in old solver if self ty is ty var)
 - rust-lang#133330 (library: update comment around close())
 - rust-lang#133337 (Fix typo in `std::thread::Scope::spawn` documentation.)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 8fdba31 into rust-lang:master Nov 22, 2024
6 checks passed
@rustbot rustbot added this to the 1.84.0 milestone Nov 22, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Nov 22, 2024
Rollup merge of rust-lang#133319 - compiler-errors:simpler-fulfill, r=lcnr

Simplify `fulfill_implication`

calm before the storm
@cuviper cuviper modified the milestones: 1.84.0, 1.85.0 Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants