Skip to content

Conversation

clubby789
Copy link
Contributor

Fixes #131810

r? @jieyouxu

@rustbot rustbot added A-compiletest Area: The compiletest test runner A-run-make Area: port run-make Makefiles to rmake.rs A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Oct 27, 2024
@rustbot
Copy link
Collaborator

rustbot commented Oct 27, 2024

The run-make-support library was changed

cc @jieyouxu

Some changes occurred in src/tools/compiletest

cc @jieyouxu

@jieyouxu
Copy link
Member

Thanks, I'll test this locally later today.

@jieyouxu
Copy link
Member

This passes for me locally, so
@bors r+ rollup=iffy

@bors
Copy link
Collaborator

bors commented Oct 28, 2024

📌 Commit 9bb6e07 has been approved by jieyouxu

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 28, 2024
bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 28, 2024
Rollup of 7 pull requests

Successful merges:

 - rust-lang#131633 (error on alignments greater than `isize::MAX`)
 - rust-lang#132086 (Tweak E0277 highlighting and "long type" path printing)
 - rust-lang#132220 (Add GUI regression test for doc struct fields margins)
 - rust-lang#132225 (Dynamically link run-make support)
 - rust-lang#132227 (Pass constness with span into lower_poly_trait_ref)
 - rust-lang#132242 (Support `char::is_digit` in const contexts.)
 - rust-lang#132243 (Remove `ObligationCause::span()` method)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit afc93a9 into rust-lang:master Oct 28, 2024
6 checks passed
@rustbot rustbot added this to the 1.84.0 milestone Oct 28, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Oct 28, 2024
Rollup merge of rust-lang#132225 - clubby789:run-make-dynamic, r=jieyouxu

Dynamically link run-make support

Fixes rust-lang#131810

r? `@jieyouxu`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-compiletest Area: The compiletest test runner A-run-make Area: port run-make Makefiles to rmake.rs A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider building/linking run-make-support as a dylib instead of a static lib
4 participants