Skip to content

Conversation

weihanglo
Copy link
Member

7 commits in 8c30ce53688e25f7e9d860b33cc914fb2957ca9a..cf53cc54bb593b5ec3dc2be4b1702f50c36d24d5
2024-10-15 16:43:16 +0000 to 2024-10-18 13:56:15 +0000

@weihanglo weihanglo self-assigned this Oct 18, 2024
@rustbot
Copy link
Collaborator

rustbot commented Oct 18, 2024

⚠️ Warning ⚠️

  • These commits modify submodules.

@rustbot
Copy link
Collaborator

rustbot commented Oct 18, 2024

Some changes occurred in src/tools/cargo

cc @ehuss

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 18, 2024
@weihanglo
Copy link
Member Author

@bors r+ rollup=never p=1

@bors
Copy link
Collaborator

bors commented Oct 19, 2024

📌 Commit e541058 has been approved by weihanglo

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 19, 2024
@bors
Copy link
Collaborator

bors commented Oct 19, 2024

⌛ Testing commit e541058 with merge b27f33a...

@bors
Copy link
Collaborator

bors commented Oct 19, 2024

☀️ Test successful - checks-actions
Approved by: weihanglo
Pushing b27f33a to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Oct 19, 2024
@bors bors merged commit b27f33a into rust-lang:master Oct 19, 2024
7 checks passed
@rustbot rustbot added this to the 1.84.0 milestone Oct 19, 2024
@weihanglo weihanglo deleted the update-cargo branch October 19, 2024 05:50
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (b27f33a): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (primary 2.7%, secondary -0.4%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
2.7% [2.7%, 2.7%] 1
Regressions ❌
(secondary)
2.3% [2.3%, 2.3%] 1
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-3.1% [-3.1%, -3.1%] 1
All ❌✅ (primary) 2.7% [2.7%, 2.7%] 1

Cycles

Results (secondary -6.5%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-6.5% [-8.9%, -3.1%] 12
All ❌✅ (primary) - - 0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 781.3s -> 783.331s (0.26%)
Artifact size: 333.79 MiB -> 333.73 MiB (-0.02%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants