Don't record trait aliases as marker traits #128174
Merged
+27
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
compiler-errors
force-pushed
the
trait-alias-marker
branch
from
e5aa489 to
12f1463
Compare
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jul 29, 2024
…iaskrgr Rollup of 6 pull requests Successful merges: - rust-lang#127882 (Don't elaborate associated types with Sized bounds in `trait_object_ty` in cfi) - rust-lang#128174 (Don't record trait aliases as marker traits) - rust-lang#128202 (Tell users not to file a bug when using internal library features) - rust-lang#128239 (Don't ICE when encountering error regions when confirming object method candidate) - rust-lang#128337 (skip assoc type during infer source visitor) - rust-lang#128341 (Make `rustc_attr::parse_version` pub) r? `@ghost` `@rustbot` modify labels: rollup
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jul 29, 2024
…iaskrgr Rollup of 6 pull requests Successful merges: - rust-lang#127882 (Don't elaborate associated types with Sized bounds in `trait_object_ty` in cfi) - rust-lang#128174 (Don't record trait aliases as marker traits) - rust-lang#128202 (Tell users not to file a bug when using internal library features) - rust-lang#128239 (Don't ICE when encountering error regions when confirming object method candidate) - rust-lang#128337 (skip assoc type during infer source visitor) - rust-lang#128341 (Make `rustc_attr::parse_version` pub) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jul 29, 2024
Rollup merge of rust-lang#128174 - compiler-errors:trait-alias-marker, r=oli-obk Don't record trait aliases as marker traits Don't record `#[marker]` on trait aliases, since we use that to check for the (non-presence of) associated types and other things which don't make sense of trait aliases. We already enforce this attr is only applied to a trait. Also do the same for `#[const_trait]`, which we also enforce is only applied to a trait. This is a drive-by change, but also worthwhile just in case. Fixes rust-lang#127222
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't record
#[marker]on trait aliases, since we use that to check for the (non-presence of) associated types and other things which don't make sense of trait aliases. We already enforce this attr is only applied to a trait.Also do the same for
#[const_trait], which we also enforce is only applied to a trait. This is a drive-by change, but also worthwhile just in case.Fixes #127222