Rollup of 9 pull requests #126716
Closed
Rollup of 9 pull requests #126716
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cause of the bound that binds the parameter's type
People were tripped up by the "precludes", interpreting it that this function must not ever be used in cryptographic contexts rather than the std lib merely making zero promises about it being fit-for-purpose. What remains unchanged is that if someone does try to use it *despite the warnings* then it is on them to pin their compiler versions and verify the assembly of every single binary build they do.
It's clearer this way, because the `Interpolated` cases in `can_begin_const_arg` and `is_pat_range_end_start` are more permissive than the `Interpolated` cases in `can_begin_literal_maybe_minus`.
We currently use `can_begin_literal_maybe_minus` in a couple of places where only string literals are allowed. This commit introduces a more specific function, which makes things clearer. It doesn't change behaviour because the two functions affected (`is_unsafe_foreign_mod` and `check_keyword_case`) are always followed by a call to `parse_abi`, which checks again for a string literal.
…youxu Migrate `link-args-order`, `ls-metadata` and `lto-readonly-lib` `run-make` tests to `rmake` Part of rust-lang#121876 and the associated [Google Summer of Code project](https://blog.rust-lang.org/2024/05/01/gsoc-2024-selected-projects.html). Guaranteed to fail CI until rust-lang#125736 gets merged. Will require addition of `fs_wrapper::set_permissions` in the associated module. try-job: x86_64-msvc
…=jieyouxu Migrate `run-make/comment-section` to `rmake.rs` Part of rust-lang#121876. r? ``@jieyouxu`` try-job: x86_64-msvc try-job: aarch64-gnu try-job: aarch64-apple
Actually taint InferCtxt when a fulfillment error is emitted And avoid checking the global error counter fixes rust-lang#122044 fixes rust-lang#123255 fixes rust-lang#123276 fixes rust-lang#125799
…mpressed-debuginfo, r=jieyouxu Migrate `run-make/compressed-debuginfo` to `rmake.rs` Part of rust-lang#121876. r? ```@jieyouxu```
Rewrite `extern-flag-rename-transitive`. `debugger-visualizer-dep-info`, `metadata-flag-frobs-symbols`, `extern-overrides-distribution` and `forced-unwind-terminate-pof` `run-make` tests to rmake Part of rust-lang#121876 and the associated [Google Summer of Code project](https://blog.rust-lang.org/2024/05/01/gsoc-2024-selected-projects.html). try-job: dist-x86_64-apple
Rename a bunch of things in the new solver and `rustc_type_ir` * Renames `interner()` to `cx()` in the solver and `TypeFolder`. * Renames `Infcx` generic param to `D` * Moves `infcx.rs` to `delegate.rs` r? lcnr
Migrate `unknown-mod-stdin`, `issue-68794-textrel-on-minimal-lib`, `raw-dylib-cross-compilation` and `used-cdylib-macos` `run-make` tests to rmake Part of rust-lang#121876 and the associated [Google Summer of Code project](https://blog.rust-lang.org/2024/05/01/gsoc-2024-selected-projects.html). Seriously needs OSX/Windows try-jobs. If it fails, restore `only-linux` in `textrel-on-minimal-lib` and try again. try-job: armhf-gnu try-job: test-various
…scottmcm reword the hint::blackbox non-guarantees People were tripped up by the "precludes", interpreting it that this function must not ever be used in cryptographic contexts rather than the std lib merely making zero promises about it being fit-for-purpose. What remains unchanged is that if someone does try to use it *despite the warnings* then it is on them to pin their compiler versions and verify the assembly of every single binary build they do.
…eral_maybe_minus, r=compiler-errors Minimize `can_begin_literal_maybe_minus` usage `can_begin_literal_maybe_minus` is used in a few confusing ways. This PR makes them clearer. r? `@spastorino`
rustbot
added
A-run-make
|
Let's make sure I don't forgor to r+ this time: |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 20, 2024
Rollup of 9 pull requests Successful merges: - rust-lang#126095 (Migrate `link-args-order`, `ls-metadata` and `lto-readonly-lib` `run-make` tests to `rmake`) - rust-lang#126534 (Migrate `run-make/comment-section` to `rmake.rs`) - rust-lang#126620 (Actually taint InferCtxt when a fulfillment error is emitted) - rust-lang#126629 (Migrate `run-make/compressed-debuginfo` to `rmake.rs`) - rust-lang#126644 (Rewrite `extern-flag-rename-transitive`. `debugger-visualizer-dep-info`, `metadata-flag-frobs-symbols`, `extern-overrides-distribution` and `forced-unwind-terminate-pof` `run-make` tests to rmake) - rust-lang#126650 (Rename a bunch of things in the new solver and `rustc_type_ir`) - rust-lang#126698 (Migrate `unknown-mod-stdin`, `issue-68794-textrel-on-minimal-lib`, `raw-dylib-cross-compilation` and `used-cdylib-macos` `run-make` tests to rmake) - rust-lang#126703 (reword the hint::blackbox non-guarantees) - rust-lang#126708 (Minimize `can_begin_literal_maybe_minus` usage) r? `@ghost` `@rustbot` modify labels: rollup
|
The job Click to see the possible cause of the failure (guessed by this bot) |
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-review
|
@bors r- |
bors
added
S-waiting-on-author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
link-args-order,ls-metadataandlto-readonly-librun-maketests tormake#126095 (Migratelink-args-order,ls-metadataandlto-readonly-librun-maketests tormake)run-make/comment-sectiontormake.rs#126534 (Migraterun-make/comment-sectiontormake.rs)run-make/compressed-debuginfotormake.rs#126629 (Migraterun-make/compressed-debuginfotormake.rs)extern-flag-rename-transitive.debugger-visualizer-dep-info,metadata-flag-frobs-symbols,extern-overrides-distributionandforced-unwind-terminate-pofrun-maketests to rmake #126644 (Rewriteextern-flag-rename-transitive.debugger-visualizer-dep-info,metadata-flag-frobs-symbols,extern-overrides-distributionandforced-unwind-terminate-pofrun-maketests to rmake)rustc_type_ir#126650 (Rename a bunch of things in the new solver andrustc_type_ir)unknown-mod-stdin,issue-68794-textrel-on-minimal-lib,raw-dylib-cross-compilationandused-cdylib-macosrun-maketests to rmake #126698 (Migrateunknown-mod-stdin,issue-68794-textrel-on-minimal-lib,raw-dylib-cross-compilationandused-cdylib-macosrun-maketests to rmake)can_begin_literal_maybe_minususage #126708 (Minimizecan_begin_literal_maybe_minususage)r? @ghost
@rustbot modify labels: rollup
Create a similar rollup