Skip to content

Conversation

Zalathar
Copy link
Contributor

@Zalathar Zalathar commented Apr 8, 2024

Extracted and squashed from #123409 by @ZhuUx.

These updates to the coverage test tools can land ahead of the main changes, slightly reducing the size and complexity of that PR.


The coverage-dump changes aren't directly tested in this PR, but the tests in #123409 demonstrate that they do work on real MC/DC coverage output.

@rustbot label +A-code-coverage

zhuyunxing and others added 2 commits April 8, 2024 21:30
We don't need the branch coverage version of this test, but we can recycle is
to make sure that the MC/DC coverage support works as expected.
@rustbot
Copy link
Collaborator

rustbot commented Apr 8, 2024

r? @oli-obk

rustbot has assigned @oli-obk.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Apr 8, 2024
@rustbot
Copy link
Collaborator

rustbot commented Apr 8, 2024

Some changes occurred in src/tools/compiletest

cc @jieyouxu

@rustbot rustbot added the A-code-coverage Area: Source-based code coverage (-Cinstrument-coverage) label Apr 8, 2024
@oli-obk
Copy link
Contributor

oli-obk commented Apr 9, 2024

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Apr 9, 2024

📌 Commit 4b35383 has been approved by oli-obk

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 9, 2024
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 9, 2024
…llaumeGomez

Rollup of 8 pull requests

Successful merges:

 - rust-lang#123254 (Do not allocate for ZST ThinBox (attempt 2 using const_allocate))
 - rust-lang#123626 (Add MC/DC support to coverage test tools)
 - rust-lang#123638 (rustdoc: synthetic auto: filter out clauses from the implementor's ParamEnv)
 - rust-lang#123653 (Split `non_local_definitions` lint tests in separate test files)
 - rust-lang#123658 (Stop making any assumption about the projections applied to the upvars in the `ByMoveBody` pass)
 - rust-lang#123662 (Don't rely on upvars being assigned just because coroutine-closure kind is assigned)
 - rust-lang#123665 (Fix typo in `Future::poll()` docs)
 - rust-lang#123672 (compiletest: unset `RUSTC_LOG_COLOR`)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit fb0aab1 into rust-lang:master Apr 9, 2024
@rustbot rustbot added this to the 1.79.0 milestone Apr 9, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Apr 9, 2024
Rollup merge of rust-lang#123626 - Zalathar:test-tools-mcdc, r=oli-obk

Add MC/DC support to coverage test tools

Extracted and squashed from rust-lang#123409 by `@ZhuUx.`

These updates to the coverage test tools can land ahead of the main changes, slightly reducing the size and complexity of that PR.

---

The `coverage-dump` changes aren't directly tested in this PR, but the tests in rust-lang#123409 demonstrate that they do work on real MC/DC coverage output.

`@rustbot` label +A-code-coverage
@Zalathar Zalathar deleted the test-tools-mcdc branch April 9, 2024 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-code-coverage Area: Source-based code coverage (-Cinstrument-coverage) A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants