Skip to content

Conversation

RalfJung
Copy link
Member

@RalfJung RalfJung commented Mar 31, 2024

Warns about the footgun in #86027.

Will be unnecessary if panics escaping from drop leads to abort (rust-lang/rfcs#3288). But until that is enforced everywhere, let's warn users about this.

@rustbot
Copy link
Collaborator

rustbot commented Mar 31, 2024

r? @workingjubilee

rustbot has assigned @workingjubilee.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Mar 31, 2024
@workingjubilee
Copy link
Member

lmao I keep forgetting about that.

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Mar 31, 2024

📌 Commit 42972f5 has been approved by workingjubilee

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 31, 2024
@bors
Copy link
Collaborator

bors commented Mar 31, 2024

⌛ Testing commit 42972f5 with merge 204805a...

@bors
Copy link
Collaborator

bors commented Mar 31, 2024

☀️ Test successful - checks-actions
Approved by: workingjubilee
Pushing 204805a to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Mar 31, 2024
@bors bors merged commit 204805a into rust-lang:master Mar 31, 2024
@rustbot rustbot added this to the 1.79.0 milestone Mar 31, 2024
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (204805a): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
3.8% [3.8%, 3.8%] 1
Improvements ✅
(primary)
-1.4% [-1.4%, -1.4%] 1
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) -1.4% [-1.4%, -1.4%] 1

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 666.819s -> 669.024s (0.33%)
Artifact size: 315.68 MiB -> 315.68 MiB (0.00%)

@RalfJung RalfJung deleted the catch-panic branch April 1, 2024 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants