Skip to content

add even more tests! #122988

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Mar 25, 2024
Merged

add even more tests! #122988

merged 10 commits into from
Mar 25, 2024

Conversation

matthiaskrgr
Copy link
Member

Fixes #109869
Fixes #110453
Fixes #109020
Fixes #108580
Fixes #108220
Fixes #113045
Fixes #113133
Fixes #114464
Fixes #116599
Fixes #119731

@rustbot
Copy link
Collaborator

rustbot commented Mar 24, 2024

r? @petrochenkov

rustbot has assigned @petrochenkov.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Mar 24, 2024
@petrochenkov
Copy link
Contributor

@bors r+

@bors
Copy link
Collaborator

bors commented Mar 25, 2024

📌 Commit e4d816e has been approved by petrochenkov

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 25, 2024
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 25, 2024
…iaskrgr

Rollup of 9 pull requests

Successful merges:

 - rust-lang#122842 (Don't emit an error about failing to produce a file with a specific name if user never gave an explicit name)
 - rust-lang#122881 (Delegation: fix ICE on `bound_vars` divergence)
 - rust-lang#122910 (Validate that we're only matching on unit struct for path pattern)
 - rust-lang#122970 (Use `chunk_by` when building `ReverseSccGraph`)
 - rust-lang#122988 (add even more tests! )
 - rust-lang#122999 (Fix unpretty UI test when /tmp does not exist)
 - rust-lang#123001 (Rename `{enter,exit}_lint_attrs` to `check_attributes{,_post}`)
 - rust-lang#123022 (Add `async-closures/once.rs` back to cranelift tests)
 - rust-lang#123034 (Add a bunch of needs-unwind annotations to tests)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 877f293 into rust-lang:master Mar 25, 2024
@rustbot rustbot added this to the 1.79.0 milestone Mar 25, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Mar 25, 2024
Rollup merge of rust-lang#122988 - matthiaskrgr:icetests, r=petrochenkov

add even more tests!

Fixes rust-lang#109869
Fixes rust-lang#110453
Fixes rust-lang#109020
Fixes rust-lang#108580
Fixes rust-lang#108220
Fixes rust-lang#113045
Fixes rust-lang#113133
Fixes rust-lang#114464
Fixes rust-lang#116599
Fixes rust-lang#119731
@bend-n
Copy link
Contributor

bend-n commented May 19, 2024

Can i add a test for #118403?

@matthiaskrgr matthiaskrgr deleted the icetests branch January 25, 2025 09:12
compiler-errors added a commit to compiler-errors/rust that referenced this pull request Jun 27, 2025
… r=BoxyUwU

Move an ACE test out of the GCI directory

In rust-lang#122988, a test pertaining to `associated_const_equality` was placed into the directory meant for `generic_const_items`. Let's move it where it belongs.

While at it, I took the time to further minimize the test and to add a description. You can use 1.67.1 (as reported in rust-lang#108220) to verify that I didn't butcher it. For additional context, the issue was likely fixed in rust-lang#112718 (but I'm also cc'ing rust-lang#140467 which further fixed things up and has more context).

I only performed quick and dirty git/GitHub archeology, so I don't have the full picture here. For one, I'm not even sure if this regression test is worth it.

Anyway, I just want it gone from the GCI dir :)
rust-timer added a commit that referenced this pull request Jun 27, 2025
Rollup merge of #143056 - fmease:mv-ace-test-out-of-gci-dir, r=BoxyUwU

Move an ACE test out of the GCI directory

In #122988, a test pertaining to `associated_const_equality` was placed into the directory meant for `generic_const_items`. Let's move it where it belongs.

While at it, I took the time to further minimize the test and to add a description. You can use 1.67.1 (as reported in #108220) to verify that I didn't butcher it. For additional context, the issue was likely fixed in #112718 (but I'm also cc'ing #140467 which further fixed things up and has more context).

I only performed quick and dirty git/GitHub archeology, so I don't have the full picture here. For one, I'm not even sure if this regression test is worth it.

Anyway, I just want it gone from the GCI dir :)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment