Fix Itanium mangling usizes #122855
Merged
Fix Itanium mangling usizes #122855
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Arrays, surprisingly, are not sized to u64 on all platforms.
rustbot
added
PG-exploit-mitigations
|
Some changes occurred in compiler/rustc_symbol_mangling/src/typeid cc @rust-lang/project-exploit-mitigations, @rcvalle |
|
LGTM. I'm guessing the confusion (I had this too when reading the code) was expecting that |
maurer
approved these changes
Mar 22, 2024
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
|
Would it be possible to validate this fixes your problem locally @maurer? No need to block the PR since it's strictly more correct imo |
slightly more complicated encoding: we shove all ints inside 16-byte arrays and then read them back out, but track what our size was. that code was actually one of the first places I ever touched in compiler PRs. |
|
Just confirmed that this removes the ICE in the build process that hit it originally. |
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Mar 22, 2024
…inism, r=compiler-errors Fix Itanium mangling usizes Arrays, surprisingly, are not sized to u64 on all platforms. Fixes rust-lang#122851. r? `@compiler-errors` cc `@maurer`
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Mar 22, 2024
…inism, r=compiler-errors Fix Itanium mangling usizes Arrays, surprisingly, are not sized to u64 on all platforms. Fixes rust-lang#122851. r? ``@compiler-errors`` cc ``@maurer``
This was referenced Mar 22, 2024
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 22, 2024
…iaskrgr Rollup of 9 pull requests Successful merges: - rust-lang#121619 (Experimental feature postfix match) - rust-lang#122370 (Gracefully handle `AnonConst` in `diagnostic_hir_wf_check()`) - rust-lang#122537 (interpret/allocation: fix aliasing issue in interpreter and refactor getters a bit) - rust-lang#122542 (coverage: Clean up marker statements that aren't needed later) - rust-lang#122800 (Add `NonNull::<[T]>::is_empty`.) - rust-lang#122820 (Stop using `<DefId as Ord>` in various diagnostic situations) - rust-lang#122847 (Suggest `RUST_MIN_STACK` workaround on overflow) - rust-lang#122855 (Fix Itanium mangling usizes) - rust-lang#122863 (add more ice tests ) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 22, 2024
Rollup merge of rust-lang#122855 - workingjubilee:mangle-64-bit-chauvinism, r=compiler-errors Fix Itanium mangling usizes Arrays, surprisingly, are not sized to u64 on all platforms. Fixes rust-lang#122851. r? ```@compiler-errors``` cc ```@maurer```
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Apr 4, 2024
…iaskrgr Rollup of 9 pull requests Successful merges: - rust-lang#121619 (Experimental feature postfix match) - rust-lang#122370 (Gracefully handle `AnonConst` in `diagnostic_hir_wf_check()`) - rust-lang#122537 (interpret/allocation: fix aliasing issue in interpreter and refactor getters a bit) - rust-lang#122542 (coverage: Clean up marker statements that aren't needed later) - rust-lang#122800 (Add `NonNull::<[T]>::is_empty`.) - rust-lang#122820 (Stop using `<DefId as Ord>` in various diagnostic situations) - rust-lang#122847 (Suggest `RUST_MIN_STACK` workaround on overflow) - rust-lang#122855 (Fix Itanium mangling usizes) - rust-lang#122863 (add more ice tests ) r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Arrays, surprisingly, are not sized to u64 on all platforms.
Fixes #122851.
r? @compiler-errors
cc @maurer