Rollup of 8 pull requests #122190

matthiaskrgr · 2024-03-08T12:22:30Z

Successful merges:

add known-bug tests for derive failure to detect packed repr #121025 (add known-bug tests for derive failure to detect packed repr)
Refactor pre-getopts command line argument handling #121194 (Refactor pre-getopts command line argument handling)
Use ControlFlow in visitors. #121563 (Use ControlFlow in visitors.)
Don't ICE in CTFE if raw/fn-ptr types differ #122173 (Don't ICE in CTFE if raw/fn-ptr types differ)
Bless tidy issues order #122175 (Bless tidy issues order)
rustc: Fix typo #122179 (rustc: Fix typo)
Fix crash in internal late lint checking #122181 (Fix crash in internal late lint checking)
interpret: update comment about read_discriminant on uninhabited variants #122183 (interpret: update comment about read_discriminant on uninhabited variants)

Failed merges:

Tweak the way we protect in-place function arguments in interpreters #122076 (Tweak the way we protect in-place function arguments in interpreters)
Diagnostic renaming 3 #122132 (Diagnostic renaming 3)

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

…acked)]` attributes that are not visible before macro expansion

…ants

…ochenkov add known-bug tests for derive failure to detect packed repr We only taint if it was a normal item. Modules and imports are untouched. Tainting them needs to be done differently, and it's unclear if that would be useful or desirable. If we just taint them into `Res::Err`, we end up losing some duplicate name messages *in the presence of other resolution errors*. r? `@petrochenkov`

…enkov Refactor pre-getopts command line argument handling Rebased version of rust-lang#111658. I've also fixed the Windows CI failure (although I don't have access to Windows to test it myself).

Use `ControlFlow` in visitors. Follow up to rust-lang#121256 This does have a few small behaviour changes in some diagnostic output where the visitor will now find the first match rather than the last match. The change in `find_anon_types.rs` has the only affected test. I don't see this being an issue as the last occurrence isn't any better of a choice than the first.

…fe, r=lcnr Don't ICE in CTFE if raw/fn-ptr types differ Fixes rust-lang#121688 r? lcnr

… r=workingjubilee Bless tidy issues order The order is not right now because of rust-lang#121248 (comment) from rust-lang#122161 (comment) r? `@workingjubilee`

rustc: Fix typo

…ash, r=oli-obk Fix crash in internal late lint checking Fixes rust-lang#122177

…ited-variant, r=tmiasko interpret: update comment about read_discriminant on uninhabited variants

matthiaskrgr · 2024-03-08T12:22:58Z

@bors r+ rollup=never p=10

bors · 2024-03-08T12:23:01Z

📌 Commit 8abeac2 has been approved by matthiaskrgr

It is now in the queue for this repository.

bors · 2024-03-08T14:52:59Z

⌛ Testing commit 8abeac2 with merge 28e8274...

…iaskrgr Rollup of 8 pull requests Successful merges: - rust-lang#121025 (add known-bug tests for derive failure to detect packed repr) - rust-lang#121194 (Refactor pre-getopts command line argument handling) - rust-lang#121563 (Use `ControlFlow` in visitors.) - rust-lang#122173 (Don't ICE in CTFE if raw/fn-ptr types differ) - rust-lang#122175 (Bless tidy issues order) - rust-lang#122179 (rustc: Fix typo) - rust-lang#122181 (Fix crash in internal late lint checking) - rust-lang#122183 (interpret: update comment about read_discriminant on uninhabited variants) Failed merges: - rust-lang#122076 (Tweak the way we protect in-place function arguments in interpreters) - rust-lang#122132 (Diagnostic renaming 3) r? `@ghost` `@rustbot` modify labels: rollup

bors · 2024-03-08T14:57:34Z

💔 Test failed - checks-actions

rust-log-analyzer · 2024-03-08T14:58:50Z

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

  SDKROOT: /Applications/Xcode_14.3.1.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX13.3.sdk
  AR: ar
##[endgroup]
curl: (28) Operation too slow. Less than 100 bytes/sec transferred the last 5 seconds
Error: Failure while executing; `/usr/bin/env /usr/local/Homebrew/Library/Homebrew/shims/shared/curl --disable --cookie /dev/null --globoff --user-agent Homebrew/4.2.9\ \(Macintosh\;\ Intel\ Mac\ OS\ X\ 13.6.4\)\ curl/8.4.0 --header Accept-Language:\ en --fail --progress-bar --silent --remote-time --output /Users/runner/Library/Caches/Homebrew/api/formula.jws.json --location --disable --cookie /dev/null --globoff --show-error --user-agent Homebrew/4.2.9\ \(Macintosh\;\ Intel\ Mac\ OS\ X\ 13.6.4\)\ curl/8.4.0 --header Accept-Language:\ en --fail --progress-bar --silent --compressed --speed-limit 100 --speed-time 5 https://formulae.brew.sh/api/formula.jws.json` exited with 28. Here's the output:

##[error]Process completed with exit code 1.
Post job cleanup.
[command]/usr/local/bin/git version

matthiaskrgr · 2024-03-08T15:11:54Z

lol
@bors rety

matthiaskrgr · 2024-03-08T15:24:28Z

@bors retry

bors · 2024-03-08T17:31:04Z

⌛ Testing commit 8abeac2 with merge a655e64...

bors · 2024-03-08T19:59:54Z

☀️ Test successful - checks-actions
Approved by: matthiaskrgr
Pushing a655e64 to master...

rust-timer · 2024-03-08T20:02:10Z

📌 Perf builds for each rolled up PR:

PR#	Message	Perf Build Sha
#121025	add known-bug tests for derive failure to detect packed repr	`3e513c4c2c66ab0c2fd138e3a53e4873277964f1` (link)
#121194	Refactor pre-getopts command line argument handling	`2d1c3361fe0fff25d8d5a8f02f9f94d8aa56e566` (link)
#121563	Use `ControlFlow` in visitors.	`d2049e2a53ae398bba7a7e3f5c9519a721d07f0f` (link)
#122173	Don't ICE in CTFE if raw/fn-ptr types differ	`079e6df43c77f89c3d6d71bf563be219286904b5` (link)
#122175	Bless tidy issues order	`1f4c0e1bed6ba336e5ee19076246c53f9f33e6df` (link)
#122179	rustc: Fix typo	`de1b1944b3846544b36a05ac21b4a9520bf938ec` (link)
#122181	Fix crash in internal late lint checking	`fd318cd5b1d3b39f6412149d5dceb8099683aefe` (link)
#122183	interpret: update comment about read_discriminant on uninha…	`2ea39767a9dce310c992f55b5bd7dfac6bf531dd` (link)

previous master: 74acabe9b0

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

rust-timer · 2024-03-08T22:09:25Z

Finished benchmarking commit (a655e64): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	6.0%	[5.6%, 6.4%]	2
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 648.792s -> 649.894s (0.17%)
Artifact size: 172.56 MiB -> 172.55 MiB (-0.01%)

Jarcho and others added 20 commits March 5, 2024 19:03

Use ControlFlow in AST visitors.

e760c44

Use ControlFlow in HIR visitors

822b10d

Make arg_expand_all not short-circuit on first error

63091b1

Refactor argument UTF-8 checking into rustc_driver::args::raw_args()

fb87e60

Use rustc_driver::args::raw_args() in Clippy

d626d13

Use rustc_driver::args::raw_args() in Miri

2d7d0bd

Add known-bug tests for derive(PartialEq) mismatches with `#[repr(p…

bed9d1f

…acked)]` attributes that are not visible before macro expansion

Don't ICE in CTFE if raw/fn-ptr types differ

025ad40

Bless tidy issues order

ece20f0

rustc: Fix typo

c2f13db

interpret: update comment about read_discriminant on uninhabited vari…

2e5f86c

…ants

Fix crash in late internal checking

c81521a

Rollup merge of rust-lang#121194 - beetrees:rustc-raw-args, r=petroch…

a8e3543

…enkov Refactor pre-getopts command line argument handling Rebased version of rust-lang#111658. I've also fixed the Windows CI failure (although I don't have access to Windows to test it myself).

Rollup merge of rust-lang#122173 - compiler-errors:ptr-equality-in-ct…

3d71bad

…fe, r=lcnr Don't ICE in CTFE if raw/fn-ptr types differ Fixes rust-lang#121688 r? lcnr

Rollup merge of rust-lang#122175 - chenyukang:yukang-fix-tidy-issues,…

af3d06c

… r=workingjubilee Bless tidy issues order The order is not right now because of rust-lang#121248 (comment) from rust-lang#122161 (comment) r? `@workingjubilee`

Rollup merge of rust-lang#122179 - heiher:fix-typo, r=lcnr

9fd60c5

rustc: Fix typo

Rollup merge of rust-lang#122181 - chenyukang:yukang-fix-late-lint-cr…

a08a5d4

…ash, r=oli-obk Fix crash in internal late lint checking Fixes rust-lang#122177

Rollup merge of rust-lang#122183 - RalfJung:read-discriminant-uninhab…

8abeac2

…ited-variant, r=tmiasko interpret: update comment about read_discriminant on uninhabited variants

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 8, 2024

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 8, 2024

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 8, 2024

bors added the merged-by-bors This PR was explicitly merged by bors. label Mar 8, 2024

bors merged commit a655e64 into rust-lang:master Mar 8, 2024

rustbot added this to the 1.78.0 milestone Mar 8, 2024

This was referenced Mar 8, 2024

Reject overly generic assoc const binding types #121258

Merged

Check for occupied niches #121174

Draft

[WIP] borrowck diagnostic migration with eager booted #104941

Closed

matthiaskrgr deleted the rollup-9ol4y30 branch March 16, 2024 18:18

lqd mentioned this pull request Dec 10, 2024

Hang from infinitely-self-recursive trait alias #133901

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Rollup of 8 pull requests #122190

Rollup of 8 pull requests #122190

Uh oh!

matthiaskrgr commented Mar 8, 2024

Uh oh!

matthiaskrgr commented Mar 8, 2024

Uh oh!

bors commented Mar 8, 2024

Uh oh!

bors commented Mar 8, 2024

Uh oh!

bors commented Mar 8, 2024

Uh oh!

rust-log-analyzer commented Mar 8, 2024

Uh oh!

matthiaskrgr commented Mar 8, 2024

Uh oh!

matthiaskrgr commented Mar 8, 2024

Uh oh!

bors commented Mar 8, 2024

Uh oh!

bors commented Mar 8, 2024

Uh oh!

rust-timer commented Mar 8, 2024

Uh oh!

rust-timer commented Mar 8, 2024

Uh oh!

Uh oh!

Rollup of 8 pull requests #122190

Rollup of 8 pull requests #122190

Uh oh!

Conversation

matthiaskrgr commented Mar 8, 2024

Uh oh!

matthiaskrgr commented Mar 8, 2024

Uh oh!

bors commented Mar 8, 2024

Uh oh!

bors commented Mar 8, 2024

Uh oh!

bors commented Mar 8, 2024

Uh oh!

rust-log-analyzer commented Mar 8, 2024

Uh oh!

matthiaskrgr commented Mar 8, 2024

Uh oh!

matthiaskrgr commented Mar 8, 2024

Uh oh!

bors commented Mar 8, 2024

Uh oh!

bors commented Mar 8, 2024

Uh oh!

rust-timer commented Mar 8, 2024

Uh oh!

rust-timer commented Mar 8, 2024

Overall result: no relevant changes - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

Uh oh!