Skip to content

Conversation

alexcrichton
Copy link
Member

Includes an upstream commit by pcwalton to improve codegen of our enums getting
moved around.

This also introduces a new commit on top of our stack of patches to fix a mingw32 build issue. I have submitted the patch upstream: http://lists.cs.uiuc.edu/pipermail/llvm-commits/Week-of-Mon-20140210/204653.html

I verified that this builds on the try bots, which amazes me because I think that c++11 is turned on now, but I guess we're still lucky!

Closes #10613 (pcwalton's patch landed)
Closes #11992 (llvm has removed these options)

@huonw
Copy link
Contributor

huonw commented Feb 12, 2014

This fixes #10613, right?

@adrientetar
Copy link
Contributor

Patch just got merged upstream.

@sanxiyn
Copy link
Contributor

sanxiyn commented Feb 12, 2014

For posterity, @pcwalton's patch is r200907, @alexcrichton's patch is r201230.

@alexcrichton
Copy link
Member Author

It does indeed close #10613 (updated PR description), and my patch has indeed landed upstream.

@alexcrichton
Copy link
Member Author

ping r?

Includes an upstream commit by pcwalton to improve codegen of our enums getting
moved around.
bors added a commit that referenced this pull request Feb 14, 2014
Includes an upstream commit by pcwalton to improve codegen of our enums getting
moved around.

This also introduces a new commit on top of our stack of patches to fix a mingw32 build issue. I have submitted the patch upstream: http://lists.cs.uiuc.edu/pipermail/llvm-commits/Week-of-Mon-20140210/204653.html

I verified that this builds on the try bots, which amazes me because I think that c++11 is turned on now, but I guess we're still lucky!

Closes #10613 (pcwalton's patch landed)
Closes #11992 (llvm has removed these options)
@bors bors closed this Feb 14, 2014
@bors bors merged commit 804955f into rust-lang:master Feb 14, 2014
@alexcrichton alexcrichton deleted the up-llvm branch February 14, 2014 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Small discriminants are causing bad code generation
5 participants