Skip to content

Conversation

ffmancera
Copy link
Contributor

When shortening the type it is necessary to take into account the --verbose flag, if it is activated, we must always show the entire type and not write it in a file.

Fixes: #119130

When shortening the type it is necessary to take into account the
`--verbose` flag, if it is activated, we must always show the entire
type and not write it in a file.

Fixes: rust-lang#119130
@rustbot
Copy link
Collaborator

rustbot commented Feb 20, 2024

r? @compiler-errors

rustbot has assigned @compiler-errors.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Feb 20, 2024
@ffmancera ffmancera force-pushed the ff/verbose_long_type branch from 11d236d to e2413d7 Compare February 20, 2024 15:36
@ffmancera ffmancera force-pushed the ff/verbose_long_type branch from e2413d7 to 6b72095 Compare February 20, 2024 22:34
@ffmancera ffmancera force-pushed the ff/verbose_long_type branch from 6b72095 to e35481f Compare February 20, 2024 22:52
@compiler-errors
Copy link
Member

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Feb 20, 2024

📌 Commit e35481f has been approved by compiler-errors

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 20, 2024
bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 21, 2024
Rollup of 7 pull requests

Successful merges:

 - rust-lang#121208 (Convert `delayed_bug`s to `bug`s.)
 - rust-lang#121288 (make rustc_expand translatable)
 - rust-lang#121304 (Add docs for extension proc-macro)
 - rust-lang#121328 (Make --verbose imply -Z write-long-types-to-disk=no)
 - rust-lang#121338 (Downgrade ambiguous_wide_pointer_comparisons suggestions to MaybeIncorrect)
 - rust-lang#121361 (diagnostic items for legacy numeric modules)
 - rust-lang#121375 (Print proper relative path for descriptive name check)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 4a205bb into rust-lang:master Feb 21, 2024
@rustbot rustbot added this to the 1.78.0 milestone Feb 21, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Feb 21, 2024
Rollup merge of rust-lang#121328 - ffmancera:ff/verbose_long_type, r=compiler-errors

Make --verbose imply -Z write-long-types-to-disk=no

When shortening the type it is necessary to take into account the `--verbose` flag, if it is activated, we must always show the entire type and not write it in a file.

Fixes: rust-lang#119130
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

--verbose should imply -Z write-long-types-to-disk=no
4 participants