Skip to content

Conversation

scottmcm
Copy link
Member

@scottmcm scottmcm commented Feb 17, 2024

To help remind forgetful people like me what step they forgot.

(If this just ICE'd, rust-lang/compiler-team#620 style, the stack trace would point me here, but since there's a "nice" error that information is lost.)

@rustbot
Copy link
Collaborator

rustbot commented Feb 17, 2024

r? @petrochenkov

rustbot has assigned @petrochenkov.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Feb 17, 2024
@rust-log-analyzer

This comment has been minimized.

To help remind forgetful people like me what step they forgot.
@petrochenkov
Copy link
Contributor

@bors r+

@bors
Copy link
Collaborator

bors commented Feb 18, 2024

📌 Commit 5793f82 has been approved by petrochenkov

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 18, 2024
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Feb 18, 2024
…rochenkov

Add help to `hir_analysis_unrecognized_intrinsic_function`

To help remind forgetful people like me what step they forgot.

(If this just ICE'd, rust-lang/compiler-team#620 style, the stack trace would point me here, but since there's a "nice" error that information is lost.)
bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 18, 2024
…llaumeGomez

Rollup of 5 pull requests

Successful merges:

 - rust-lang#121067 (make "invalid fragment specifier" translatable)
 - rust-lang#121079 (distribute tool documentations and avoid file conflicts on `x install`)
 - rust-lang#121230 (Extend Level API)
 - rust-lang#121241 (Implement `NonZero` traits generically.)
 - rust-lang#121247 (Add help to `hir_analysis_unrecognized_intrinsic_function`)

r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 18, 2024
…iaskrgr

Rollup of 7 pull requests

Successful merges:

 - rust-lang#118569 (Move `OsStr::slice_encoded_bytes` validation to platform modules)
 - rust-lang#121067 (make "invalid fragment specifier" translatable)
 - rust-lang#121224 (Remove unnecessary unit binding)
 - rust-lang#121247 (Add help to `hir_analysis_unrecognized_intrinsic_function`)
 - rust-lang#121257 (remove extraneous text from example config)
 - rust-lang#121260 (Remove const_prop.rs)
 - rust-lang#121266 (Add uncontroversial syscall doc aliases to std docs)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 57d9523 into rust-lang:master Feb 18, 2024
@rustbot rustbot added this to the 1.78.0 milestone Feb 18, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Feb 18, 2024
Rollup merge of rust-lang#121247 - scottmcm:intrinsic-reminder, r=petrochenkov

Add help to `hir_analysis_unrecognized_intrinsic_function`

To help remind forgetful people like me what step they forgot.

(If this just ICE'd, rust-lang/compiler-team#620 style, the stack trace would point me here, but since there's a "nice" error that information is lost.)
Noratrieb pushed a commit to Noratrieb/rust that referenced this pull request Feb 18, 2024
…iaskrgr

Rollup of 7 pull requests

Successful merges:

 - rust-lang#118569 (Move `OsStr::slice_encoded_bytes` validation to platform modules)
 - rust-lang#121067 (make "invalid fragment specifier" translatable)
 - rust-lang#121224 (Remove unnecessary unit binding)
 - rust-lang#121247 (Add help to `hir_analysis_unrecognized_intrinsic_function`)
 - rust-lang#121257 (remove extraneous text from example config)
 - rust-lang#121260 (Remove const_prop.rs)
 - rust-lang#121266 (Add uncontroversial syscall doc aliases to std docs)

r? `@ghost`
`@rustbot` modify labels: rollup
@scottmcm scottmcm deleted the intrinsic-reminder branch February 18, 2024 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants