Skip to content

rustc_codegen_ssa: Enforce rustc::potential_query_instability lint #119409

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 13, 2024
Merged

rustc_codegen_ssa: Enforce rustc::potential_query_instability lint #119409

merged 1 commit into from
Jan 13, 2024
+30 −11

Conversation

Kobzol
Copy link
Member

@Kobzol Kobzol commented Dec 29, 2023

Part of #84447.

@rustbot
Copy link
Collaborator

rustbot commented Dec 29, 2023

r? @TaKO8Ki

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Dec 29, 2023
Noratrieb
Noratrieb reviewed Dec 29, 2023
View reviewed changes
@Kobzol Kobzol force-pushed the rustc-codegen-ssa-query-instability branch from 374d05d to 4612edc Compare January 13, 2024 15:06
@Noratrieb
Copy link
Member

@bors r+

@bors
Copy link
Collaborator

bors commented Jan 13, 2024

📌 Commit 4612edc has been approved by Nilstrieb

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 13, 2024
@bors
Copy link
Collaborator

bors commented Jan 13, 2024

⌛ Testing commit 4612edc with merge 23148b1...

@bors
Copy link
Collaborator

bors commented Jan 13, 2024

☀️ Test successful - checks-actions
Approved by: Nilstrieb
Pushing 23148b1 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jan 13, 2024
@bors bors merged commit 23148b1 into rust-lang:master Jan 13, 2024
@rustbot rustbot added this to the 1.77.0 milestone Jan 13, 2024
@Kobzol Kobzol deleted the rustc-codegen-ssa-query-instability branch January 13, 2024 20:35
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (23148b1): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 4.9% [4.9%, 4.9%] 1
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -4.8% [-5.2%, -4.4%] 2
All ❌✅ (primary) - - 0

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 667.459s -> 667.979s (0.08%)
Artifact size: 308.16 MiB -> 308.20 MiB (0.01%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Noratrieb Noratrieb Noratrieb approved these changes

Assignees

@TaKO8Ki TaKO8Ki

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.77.0
Development

Successfully merging this pull request may close these issues.
6 participants
@Kobzol @rustbot @Noratrieb @bors @rust-timer @TaKO8Ki