Skip to content

Conversation

WaffleLapkin
Copy link
Member

(my employer asks me to commit upstreaming under my work email)

@rustbot
Copy link
Collaborator

rustbot commented Nov 26, 2023

r? @Mark-Simulacrum

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added A-meta Area: Issues & PRs about the rust-lang/rust repository itself S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 26, 2023
@Mark-Simulacrum
Copy link
Member

@bors r+

@bors
Copy link
Collaborator

bors commented Nov 26, 2023

📌 Commit 41a9788 has been approved by Mark-Simulacrum

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 26, 2023
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Nov 26, 2023
…k-Simulacrum

Add my work email to the mailmap

(my employer asks me to commit upstreaming under my work email)
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 26, 2023
…llaumeGomez

Rollup of 4 pull requests

Successful merges:

 - rust-lang#118321 (rustdoc: Remove space from fake-variadic fn ptr impls)
 - rust-lang#118322 (skip {tidy,compiletest,rustdoc-gui} based tests for `DocTests::Only`)
 - rust-lang#118325 (Fix Rustdoc search docs link)
 - rust-lang#118327 (Add my work email to the mailmap)

r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 26, 2023
…llaumeGomez

Rollup of 4 pull requests

Successful merges:

 - rust-lang#118321 (rustdoc: Remove space from fake-variadic fn ptr impls)
 - rust-lang#118322 (skip {tidy,compiletest,rustdoc-gui} based tests for `DocTests::Only`)
 - rust-lang#118325 (Fix Rustdoc search docs link)
 - rust-lang#118327 (Add my work email to the mailmap)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors
Copy link
Collaborator

bors commented Nov 27, 2023

⌛ Testing commit 41a9788 with merge 48cfbe0...

@bors
Copy link
Collaborator

bors commented Nov 27, 2023

☀️ Test successful - checks-actions
Approved by: Mark-Simulacrum
Pushing 48cfbe0 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Nov 27, 2023
@bors bors merged commit 48cfbe0 into rust-lang:master Nov 27, 2023
@rustbot rustbot added this to the 1.76.0 milestone Nov 27, 2023
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (48cfbe0): comparison URL.

Overall result: ❌ regressions - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
1.0% [1.0%, 1.0%] 1
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) - - 0

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
4.0% [4.0%, 4.0%] 1
Regressions ❌
(secondary)
3.5% [3.5%, 3.5%] 1
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 4.0% [4.0%, 4.0%] 1

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-2.2% [-2.2%, -2.2%] 1
All ❌✅ (primary) - - 0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 675.005s -> 674.035s (-0.14%)
Artifact size: 313.35 MiB -> 313.34 MiB (-0.00%)

@WaffleLapkin WaffleLapkin deleted the mailmap-wl-tsk branch November 27, 2023 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-meta Area: Issues & PRs about the rust-lang/rust repository itself merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants