Skip to content

Conversation

compiler-errors
Copy link
Member

I could fix this the right way, though I don't really want to think about the implications of the change. This should have minimal side-effects.

r? @aliemjay

Fixes #118286

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Nov 25, 2023
@aliemjay
Copy link
Member

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Nov 25, 2023

📌 Commit 1279f70 has been approved by aliemjay

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 25, 2023
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 25, 2023
…mpiler-errors

Rollup of 7 pull requests

Successful merges:

 - rust-lang#117651 (coverage: Simplify building coverage expressions based on sums)
 - rust-lang#117968 (Stabilize `ptr::addr_eq`)
 - rust-lang#118158 (Reduce fluent boilerplate)
 - rust-lang#118201 (Miscellaneous `ObligationCauseCode` cleanups)
 - rust-lang#118288 (Use `is_{some,ok}_and` more in the compiler)
 - rust-lang#118289 (`is_{some,ok}_and` for rustdoc)
 - rust-lang#118290 (Don't ICE when encountering placeholders in implied bounds computation)

r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 26, 2023
…mpiler-errors

Rollup of 7 pull requests

Successful merges:

 - rust-lang#117651 (coverage: Simplify building coverage expressions based on sums)
 - rust-lang#117968 (Stabilize `ptr::addr_eq`)
 - rust-lang#118158 (Reduce fluent boilerplate)
 - rust-lang#118201 (Miscellaneous `ObligationCauseCode` cleanups)
 - rust-lang#118288 (Use `is_{some,ok}_and` more in the compiler)
 - rust-lang#118289 (`is_{some,ok}_and` for rustdoc)
 - rust-lang#118290 (Don't ICE when encountering placeholders in implied bounds computation)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 2eccebb into rust-lang:master Nov 26, 2023
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Nov 26, 2023
Rollup merge of rust-lang#118290 - compiler-errors:placeholder-implied, r=aliemjay

Don't ICE when encountering placeholders in implied bounds computation

I *could* fix this the right way, though I don't really want to think about the implications of the change. This should have minimal side-effects.

r? `@aliemjay`

Fixes rust-lang#118286
@rustbot rustbot added this to the 1.76.0 milestone Nov 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ICE: Shouldn't expect a placeholder type in implied bounds (yet) When return type in trait impl is &impl Trait
4 participants