Skip to content

Conversation

onur-ozkan
Copy link
Contributor

@onur-ozkan onur-ozkan commented Nov 22, 2023

Utilize a smart hash for 'llvm-finished-building' to enable recompilation of LLVM with each change in the git sources.

Each change generates a unique hash value in 'llvm-finished-building', which ensures LLVM compilations only triggered with further changes.

Resolves #111893

cc @rust-lang/wg-llvm

@rustbot
Copy link
Collaborator

rustbot commented Nov 22, 2023

r? @clubby789

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Nov 22, 2023
@rustbot
Copy link
Collaborator

rustbot commented Nov 22, 2023

This PR changes how LLVM is built. Consider updating src/bootstrap/download-ci-llvm-stamp.

@onur-ozkan onur-ozkan force-pushed the recompile-llvm-on-changes branch from e6f82d6 to 53de5d0 Compare November 22, 2023 21:38
Utilize a smart hash for 'llvm-finished-building' to enable
recompilation of LLVM with each change in the git sources.

Each change generates a unique hash value in 'llvm-finished-building',
which ensures LLVM compilations only triggered with further changes.

Signed-off-by: onur-ozkan <[email protected]>
@onur-ozkan onur-ozkan force-pushed the recompile-llvm-on-changes branch from 53de5d0 to 111ad61 Compare November 22, 2023 21:44
@clubby789
Copy link
Contributor

@bors r+

@bors
Copy link
Collaborator

bors commented Nov 24, 2023

📌 Commit 111ad61 has been approved by clubby789

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 24, 2023
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 24, 2023
…mpiler-errors

Rollup of 7 pull requests

Successful merges:

 - rust-lang#118187 (Recompile LLVM when it changes in the git sources)
 - rust-lang#118210 (intercrate ambiguity causes: ignore candidates which don't apply)
 - rust-lang#118215 (Add common trait for crate definitions)
 - rust-lang#118238 (memcpy assumptions: update GCC link)
 - rust-lang#118243 (EvalCtxt::commit_if_ok don't inherit nested goals)
 - rust-lang#118245 (Add `Span` to `TraitBoundModifier`)
 - rust-lang#118246 (Remove a hack for effects)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 7f974b9 into rust-lang:master Nov 24, 2023
@rustbot rustbot added this to the 1.76.0 milestone Nov 24, 2023
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Nov 24, 2023
Rollup merge of rust-lang#118187 - onur-ozkan:recompile-llvm-on-changes, r=clubby789

Recompile LLVM when it changes in the git sources

Utilize a smart hash for 'llvm-finished-building' to enable recompilation of LLVM with each change in the git sources.

Each change generates a unique hash value in 'llvm-finished-building', which ensures LLVM compilations only triggered with further changes.

Resolves rust-lang#111893

cc `@rust-lang/wg-llvm`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bootstrap should rebuild LLVM when it changes
4 participants