Make rustc_parse_format compile again on stable #117933
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
|
Duplicate of #117819 |
|
I guess I can approve your PR but I'm not sure why my PR wasn't approved yet, maybe ppl want to block it on CI changes (see discussion over at the linked PR). |
|
Oh, sorry, somehow I didn't notice yours! |
|
Since this unblocks an r-a sync I presume, I'm just gonna approve this PR. I'm gonna open a t-bootstrap/t-infra ticket for building compiler crates which ought to compile on stable without @bors r+ rollup |
|
Oh, no worries >.< |
|
It doesn't block the sync itself, just us from using a newer version of this crate. |
fmease
removed
the
S-waiting-on-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/rust-lang/rust/pull/115948/files#r1385932710
r? @fmease