Suggest dereferencing the LHS for binops such as &T == T
#117893
Merged
+71
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @wesleywiser (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
wesleywiser
approved these changes
Nov 14, 2023
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 14, 2023
…iaskrgr Rollup of 5 pull requests Successful merges: - rust-lang#116244 (Apply structured suggestion that allows test to work since 1.64) - rust-lang#117686 (Build pre-coroutine-transform coroutine body on error) - rust-lang#117834 (target_feature: make it more clear what that 'Option' means) - rust-lang#117893 (Suggest dereferencing the LHS for binops such as `&T == T`) - rust-lang#117911 (Fix some typos) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 15, 2023
Rollup merge of rust-lang#117893 - sjwang05:issue-52544-take-1, r=wesleywiser Suggest dereferencing the LHS for binops such as `&T == T` Fixes rust-lang#52544
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #52544