Create an `AllocId` for `ConstValue::Slice`. #116707

cjgillot · 2023-10-13T20:39:21Z

This PR modifies ConstValue::Slice to use an AllocId instead of directly manipulating the allocation. This was originally proposed by #115764 but was a perf regression.

Almost 2 years later, enough code has changed to make this a perf improvement: #116707 (comment)

cjgillot · 2023-10-13T20:39:40Z

@bors try @rust-timer queue

bors · 2023-10-13T20:40:49Z

⌛ Trying commit 334753f with merge 9ef21e1...

Create an `AllocId` for `ConstValue::Slice`. r? `@ghost`

bors · 2023-10-13T21:53:15Z

☀️ Try build successful - checks-actions
Build commit: 9ef21e1 (9ef21e1d83c6c9220b072fd1a4f225949514cc28)

RalfJung · 2023-10-13T22:02:01Z

How does this differ from the almost identical perf experiment I did a few weeks ago? Here are the perf results.

rust-timer · 2023-10-14T00:18:48Z

Finished benchmarking commit (9ef21e1): comparison URL.

Overall result: ❌✅ regressions and improvements - ACTION NEEDED

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	1.7%	[1.7%, 1.7%]	1
Regressions ❌ (secondary)	2.5%	[0.4%, 7.7%]	7
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-1.2%	[-1.3%, -1.0%]	3
All ❌✅ (primary)	1.7%	[1.7%, 1.7%]	1

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	1.5%	[0.9%, 2.2%]	3
Regressions ❌ (secondary)	3.8%	[0.8%, 14.5%]	17
Improvements ✅ (primary)	-1.6%	[-1.6%, -1.6%]	1
Improvements ✅ (secondary)	-5.3%	[-10.2%, -0.9%]	16
All ❌✅ (primary)	0.7%	[-1.6%, 2.2%]	4

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	7.0%	[2.1%, 21.5%]	14
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Binary size

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.1%	[0.0%, 0.3%]	30
Regressions ❌ (secondary)	0.0%	[0.0%, 0.1%]	9
Improvements ✅ (primary)	-0.0%	[-0.1%, -0.0%]	3
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.1%	[-0.1%, 0.3%]	33

Bootstrap: 628.692s -> 625.904s (-0.44%)
Artifact size: 271.29 MiB -> 271.29 MiB (0.00%)

cjgillot · 2023-10-14T10:26:37Z

No real difference. I just couldn't find your version.
Now there is one.

@bors try @rust-timer queue

bors · 2023-10-14T10:27:48Z

⌛ Trying commit e195fe8 with merge eafbd55...

Create an `AllocId` for `ConstValue::Slice`. r? `@ghost`

bors · 2023-10-14T11:40:41Z

☀️ Try build successful - checks-actions
Build commit: eafbd55 (eafbd55f7123e31b30c2f3224a91d6db75e48c3f)

rust-timer · 2023-10-14T21:03:51Z

Finished benchmarking commit (eafbd55): comparison URL.

Overall result: ❌✅ regressions and improvements - ACTION NEEDED

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.6%	[0.1%, 1.8%]	4
Regressions ❌ (secondary)	1.7%	[0.2%, 7.8%]	12
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-1.1%	[-1.2%, -1.0%]	3
All ❌✅ (primary)	0.6%	[0.1%, 1.8%]	4

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	1.6%	[1.2%, 2.1%]	3
Regressions ❌ (secondary)	2.9%	[1.1%, 8.7%]	15
Improvements ✅ (primary)	-1.9%	[-3.3%, -0.5%]	2
Improvements ✅ (secondary)	-6.0%	[-9.9%, -1.0%]	19
All ❌✅ (primary)	0.2%	[-3.3%, 2.1%]	5

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	8.0%	[2.6%, 13.7%]	4
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.5%	[-2.5%, -2.5%]	1
All ❌✅ (primary)	-	-	0

Binary size

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.1%	[0.0%, 0.3%]	30
Regressions ❌ (secondary)	0.0%	[0.0%, 0.1%]	9
Improvements ✅ (primary)	-0.1%	[-0.1%, -0.0%]	3
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.1%	[-0.1%, 0.3%]	33

Bootstrap: 627.527s -> 627.366s (-0.03%)
Artifact size: 271.26 MiB -> 271.31 MiB (0.02%)

cjgillot · 2025-07-13T13:17:13Z

@bors try @rust-timer queue

src/tools/miri/tests/pass/const-addrs.rs

RalfJung · 2025-07-17T05:54:12Z

LGTM, please squash the history a little.
@rustbot author

rustbot · 2025-07-17T05:54:16Z

Reminder, once the PR becomes ready for a review, use @rustbot ready.

bors · 2025-07-17T16:25:04Z

☔ The latest upstream changes (presumably #144058) made this pull request unmergeable. Please resolve the merge conflicts.

RalfJung · 2025-07-18T06:22:45Z

@bors r=oli-obk,RalfJung

bors · 2025-07-18T06:22:48Z

📌 Commit 2bab5bf has been approved by oli-obk,RalfJung

It is now in the queue for this repository.

Create an `AllocId` for `ConstValue::Slice`. This PR modifies `ConstValue::Slice` to use an `AllocId` instead of directly manipulating the allocation. This was originally proposed by #115764 but was a perf regression. Almost 2 years later, enough code has changed to make this a perf improvement: #116707 (comment)

bors · 2025-07-18T12:47:52Z

⌛ Testing commit 2bab5bf with merge 21fd151...

rust-log-analyzer · 2025-07-18T13:24:08Z

The job aarch64-apple failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

test [crashes] tests/crashes/120873.rs ... ok
test [crashes] tests/crashes/120911.rs ... ok
test [crashes] tests/crashes/121176.rs ... ignored, ignored if rustc wasn't built with debug assertions
test [crashes] tests/crashes/121097.rs ... ok
2025-07-18T13:23:36.136162Z ERROR compiletest::runtest: fatal error, panic: "crashtest no longer crashes/triggers ICE, hooray! Please give it a meaningful name, add a doc-comment to the start of the test explaining why it exists and move it to tests/ui or wherever you see fit. Adding 'Fixes #<issueNr>' to your PR description ensures that the corresponding ticket is auto-closed upon merge. If you want to see verbose output, set `COMPILETEST_VERBOSE_CRASHES=1`."
test [crashes] tests/crashes/121363.rs ... FAILED
test [crashes] tests/crashes/121575.rs ... ok
test [crashes] tests/crashes/121858.rs ... ok
test [crashes] tests/crashes/121963.rs ... ok
test [crashes] tests/crashes/122259.rs ... ok
---
test [crashes] tests/crashes/140123-3.rs ... ok
test [crashes] tests/crashes/140123.rs ... ok
test [crashes] tests/crashes/140123-4.rs ... ok
test [crashes] tests/crashes/140275.rs ... ok
2025-07-18T13:23:38.092795Z ERROR compiletest::runtest: fatal error, panic: "crashtest no longer crashes/triggers ICE, hooray! Please give it a meaningful name, add a doc-comment to the start of the test explaining why it exists and move it to tests/ui or wherever you see fit. Adding 'Fixes #<issueNr>' to your PR description ensures that the corresponding ticket is auto-closed upon merge. If you want to see verbose output, set `COMPILETEST_VERBOSE_CRASHES=1`."
test [crashes] tests/crashes/140365.rs ... FAILED
test [crashes] tests/crashes/140303.rs ... ok
test [crashes] tests/crashes/140479.rs ... ok
test [crashes] tests/crashes/140381.rs ... ok
test [crashes] tests/crashes/140609.rs ... ok
---
failures:

---- [crashes] tests/crashes/121363.rs stdout ----

error: crashtest no longer crashes/triggers ICE, hooray! Please give it a meaningful name, add a doc-comment to the start of the test explaining why it exists and move it to tests/ui or wherever you see fit. Adding 'Fixes #<issueNr>' to your PR description ensures that the corresponding ticket is auto-closed upon merge. If you want to see verbose output, set `COMPILETEST_VERBOSE_CRASHES=1`.

thread '[crashes] tests/crashes/121363.rs' panicked at src/tools/compiletest/src/runtest/crashes.rs:17:18:
fatal error
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

---- [crashes] tests/crashes/140365.rs stdout ----

error: crashtest no longer crashes/triggers ICE, hooray! Please give it a meaningful name, add a doc-comment to the start of the test explaining why it exists and move it to tests/ui or wherever you see fit. Adding 'Fixes #<issueNr>' to your PR description ensures that the corresponding ticket is auto-closed upon merge. If you want to see verbose output, set `COMPILETEST_VERBOSE_CRASHES=1`.

thread '[crashes] tests/crashes/140365.rs' panicked at src/tools/compiletest/src/runtest/crashes.rs:17:18:
fatal error

bors · 2025-07-18T13:25:24Z

💔 Test failed - checks-actions

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Oct 13, 2023

This comment has been minimized.

Sign in to view

rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Oct 13, 2023

bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 13, 2023

Auto merge of rust-lang#116707 - cjgillot:slice-id, r=<try>

9ef21e1

Create an `AllocId` for `ConstValue::Slice`. r? `@ghost`

This comment has been minimized.

Sign in to view

rustbot added perf-regression Performance regression. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels Oct 14, 2023

This comment has been minimized.

Sign in to view

rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Oct 14, 2023

bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 14, 2023

Auto merge of rust-lang#116707 - cjgillot:slice-id, r=<try>

eafbd55

Create an `AllocId` for `ConstValue::Slice`. r? `@ghost`

This comment has been minimized.

Sign in to view

rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Oct 14, 2023

Dylan-DPC added S-experimental Status: Ongoing experiment that does not require reviewing and won't be merged in its current state. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 16, 2024

cjgillot force-pushed the slice-id branch from e195fe8 to 766af91 Compare April 7, 2024 15:01

This comment has been minimized.

Sign in to view

cjgillot force-pushed the slice-id branch from 766af91 to 47bdbd3 Compare July 13, 2025 13:06

rustbot added the T-clippy Relevant to the Clippy team. label Jul 13, 2025

RalfJung reviewed Jul 15, 2025

View reviewed changes

src/tools/miri/tests/pass/const-addrs.rs Outdated Show resolved Hide resolved

cjgillot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 17, 2025

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 17, 2025

cjgillot force-pushed the slice-id branch from b94c764 to b0e2277 Compare July 17, 2025 10:30

cjgillot added 4 commits July 17, 2025 22:28

Give an AllocId to ConstValue::Slice.

b5d3eb7

Remove useless lifetime parameter.

15a27f3

Move crash test.

bcbcdec

Remove const deduplication from the interpreter.

2bab5bf

cjgillot force-pushed the slice-id branch from b0e2277 to 2bab5bf Compare July 17, 2025 22:51

cjgillot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 18, 2025

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 18, 2025

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 18, 2025

Create an AllocId for ConstValue::Slice. #116707

Are you sure you want to change the base?

Create an AllocId for ConstValue::Slice. #116707

Conversation

cjgillot commented Oct 13, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cjgillot commented Oct 13, 2023

Uh oh!

This comment has been minimized.

bors commented Oct 13, 2023

Uh oh!

bors commented Oct 13, 2023

Uh oh!

This comment has been minimized.

RalfJung commented Oct 13, 2023

Uh oh!

rust-timer commented Oct 14, 2023

Overall result: ❌✅ regressions and improvements - ACTION NEEDED

Uh oh!

cjgillot commented Oct 14, 2023

Uh oh!

This comment has been minimized.

bors commented Oct 14, 2023

Uh oh!

This comment has been minimized.

bors commented Oct 14, 2023

Uh oh!

This comment has been minimized.

rust-timer commented Oct 14, 2023

Overall result: ❌✅ regressions and improvements - ACTION NEEDED

Uh oh!

This comment has been minimized.

cjgillot commented Jul 13, 2025

Uh oh!

Uh oh!

RalfJung commented Jul 17, 2025

Uh oh!

rustbot commented Jul 17, 2025

Uh oh!

bors commented Jul 17, 2025

Uh oh!

RalfJung commented Jul 18, 2025

Uh oh!

bors commented Jul 18, 2025

Uh oh!

bors commented Jul 18, 2025

Uh oh!

rust-log-analyzer commented Jul 18, 2025

Uh oh!

bors commented Jul 18, 2025

Uh oh!

Uh oh!

Create an `AllocId` for `ConstValue::Slice`. #116707

Create an `AllocId` for `ConstValue::Slice`. #116707

cjgillot commented Oct 13, 2023 •

edited

Loading