Custom code classes in docs warning #115947
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
|
Some changes occurred in HTML/CSS/JS. cc @GuillaumeGomez, @jsha |
GuillaumeGomez
force-pushed
the
custom_code_classes_in_docs-warning
branch
from
46e7b41 to
1ac06dd
Compare
|
Could this be adjusted so that In the sample grammar, that means changing the syntax for barewords. -bareword = CHAR *(CHAR)
+bareword = LEADINGCHAR *(CHAR)
-CHAR = ALPHA / DIGIT / "_" / "-" / ":"
+LEADINGCHAR = ALPHA / DIGIT / "_" / "-" / ":"
+; all ASCII punctuation except comma, quote, equals, backslash, grave (backquote), and braces
+; comma is used to separate language tokens, so it can't be used in one
+; quote is used to allow otherwise-disallowed characters in language tokens
+; equals is used to make key=value pairs in attribute blocks
+; backslash and grave are special Markdown characters
+; braces are used to start an attribute block
+CHAR = ALPHA / DIGIT / "_" / "-" / ":" / "." / "!" / "#" / "$" / "%" / "&" / "*" / "+" / "/" / ";" / "<" / ">" / "?" / "@" / "^" / "|" / "~" |
|
Sounds good to me as well. I'll update it tomorrow then. |
GuillaumeGomez
force-pushed
the
custom_code_classes_in_docs-warning
branch
from
1ac06dd to
295ec09
Compare
|
I modified the eBNF as suggested. |
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 19, 2023
…llaumeGomez Rollup of 6 pull requests Successful merges: - rust-lang#113383 (style-guide: Add section on bugs, and resolving bugs) - rust-lang#115499 (rustc_target/riscv: Fix passing of transparent unions with only one non-ZST member) - rust-lang#115801 (Detect cycle errors hidden by opaques during monomorphization) - rust-lang#115947 (Custom code classes in docs warning) - rust-lang#115957 (fix mismatched symbols) - rust-lang#115958 (explain mysterious addition in float minimum/maximum) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 19, 2023
Rollup merge of rust-lang#115947 - GuillaumeGomez:custom_code_classes_in_docs-warning, r=notriddle Custom code classes in docs warning Fixes rust-lang#115938. This PR does two things: 1. Unless the `custom_code_classes_in_docs` feature is enabled, it will use the old codeblock tag parser. 2. If there is a codeblock tag that starts with a `.`, it will emit a behaviour change warning. Hopefully this is the last missing part for this feature until stabilization. Follow-up of rust-lang#110800. r? `@notriddle`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #115938.
This PR does two things:
custom_code_classes_in_docsfeature is enabled, it will use the old codeblock tag parser.., it will emit a behaviour change warning.Hopefully this is the last missing part for this feature until stabilization.
Follow-up of #110800.
r? @notriddle