Skip to content

Conversation

Mark-Simulacrum
Copy link
Member

This avoids issues with the GitHub /archive/ links which can be somewhat unreliable and are currently causing CI issues.

This avoids issues with the GitHub /archive/ links which can be somewhat
unreliable and are currently causing CI issues.
@rustbot
Copy link
Collaborator

rustbot commented Sep 4, 2023

@Mark-Simulacrum: no appropriate reviewer found, use r? to override

@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Sep 4, 2023
@ehuss
Copy link
Contributor

ehuss commented Sep 4, 2023

@bors r+ p=101

@bors
Copy link
Collaborator

bors commented Sep 4, 2023

📌 Commit fe6c863 has been approved by ehuss

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented Sep 4, 2023

🌲 The tree is currently closed for pull requests below priority 100. This pull request will be tested once the tree is reopened.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 4, 2023
@bors
Copy link
Collaborator

bors commented Sep 4, 2023

⌛ Testing commit fe6c863 with merge ec08a03...

@bors
Copy link
Collaborator

bors commented Sep 4, 2023

☀️ Test successful - checks-actions
Approved by: ehuss
Pushing ec08a03 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Sep 4, 2023
@bors bors merged commit ec08a03 into rust-lang:master Sep 4, 2023
@rustbot rustbot added this to the 1.74.0 milestone Sep 4, 2023
@Kobzol
Copy link
Member

Kobzol commented Sep 4, 2023

@bors treeclosed-

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (ec08a03): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-2.1% [-2.1%, -2.1%] 1
Improvements ✅
(secondary)
-3.4% [-3.4%, -3.4%] 1
All ❌✅ (primary) -2.1% [-2.1%, -2.1%] 1

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 627.22s -> 629.118s (0.30%)
Artifact size: 316.03 MiB -> 316.16 MiB (0.04%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants