Skip to content

Conversation

cuviper
Copy link
Member

@cuviper cuviper commented Aug 18, 2023

cuviper and others added 4 commits August 17, 2023 19:36
`Ok(0)` is indeed something the caller may interpret as an error, but
that's the *correct* thing to return if the writer can't accept any more
bytes.

(cherry picked from commit 5210f48)
@rustbot
Copy link
Collaborator

rustbot commented Aug 18, 2023

⚠️ Warning ⚠️

  • Pull requests are usually filed against the master branch for this repo, but this one is against beta. Please double check that you specified the right target!

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Aug 18, 2023
@cuviper
Copy link
Member Author

cuviper commented Aug 18, 2023

@bors r+ rollup=never p=1

@bors
Copy link
Collaborator

bors commented Aug 18, 2023

📌 Commit 402cc35 has been approved by cuviper

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 18, 2023
@bors
Copy link
Collaborator

bors commented Aug 18, 2023

⌛ Testing commit 402cc35 with merge 7a3a43a...

@bors
Copy link
Collaborator

bors commented Aug 18, 2023

☀️ Test successful - checks-actions
Approved by: cuviper
Pushing 7a3a43a to beta...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Aug 18, 2023
@bors bors merged commit 7a3a43a into rust-lang:beta Aug 18, 2023
@rustbot rustbot added this to the 1.72.0 milestone Aug 18, 2023
@cuviper cuviper deleted the beta-next branch August 20, 2023 23:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants