Skip to content

Add check before suggest removing parens #114779

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 16, 2023
Merged

Add check before suggest removing parens #114779

merged 2 commits into from
Aug 16, 2023

Conversation

mu001999
Copy link
Contributor

Fixes #114701

@rustbot
Copy link
Collaborator

rustbot commented Aug 13, 2023

r? @petrochenkov

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Aug 13, 2023
petrochenkov
petrochenkov reviewed Aug 15, 2023
View reviewed changes
@petrochenkov petrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 15, 2023
@mu001999
Copy link
Contributor Author

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 15, 2023
@mu001999 mu001999 requested a review from petrochenkov August 15, 2023 12:56
@petrochenkov
Copy link
Contributor

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Aug 16, 2023

📌 Commit 860fc24 has been approved by petrochenkov

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 16, 2023
@matthiaskrgr matthiaskrgr mentioned this pull request Aug 16, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 16, 2023
@bors
Auto merge of rust-lang#114879 - matthiaskrgr:rollup-tim571q, r=matth…
60713f4 
…iaskrgr

Rollup of 7 pull requests

Successful merges:

 - rust-lang#114721 (Optimizing the rest of bool's Ord implementation)
 - rust-lang#114746 (Don't add associated type bound for non-types)
 - rust-lang#114779 (Add check before suggest removing parens)
 - rust-lang#114859 (Add trait related queries to SMIR's rustc_internal)
 - rust-lang#114861 (fix typo: affect -> effect)
 - rust-lang#114867 ([nit] Fix a comment typo.)
 - rust-lang#114871 (Update the link in the docs of `std::intrinsics`)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 8f1c811 into rust-lang:master Aug 16, 2023
@rustbot rustbot added this to the 1.73.0 milestone Aug 16, 2023
@mu001999 mu001999 deleted the fix/114701 branch March 11, 2024 05:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petrochenkov petrochenkov Awaiting requested review from petrochenkov

Assignees

@petrochenkov petrochenkov

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.73.0
Development

Successfully merging this pull request may close these issues.

E0618 generates invalid suggestion / zero length span
4 participants
@mu001999 @rustbot @petrochenkov @bors