Skip to content

Conversation

Kobzol
Copy link
Member

@Kobzol Kobzol commented Aug 3, 2023

Slight improvement of #113040. This makes sure that if PGO is used, remarks generated using -Zremark-dir will include the Hotness attribute.

r? @tmiasko

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Aug 3, 2023
@rust-log-analyzer

This comment has been minimized.

This makes sure that if PGO is used, remarks generated using `-Zremark-dir` will include the `Hotness` attribute.
@Kobzol Kobzol force-pushed the remark-pgo-hotness branch from ad8cc88 to 93bdc01 Compare August 4, 2023 08:31
@tmiasko
Copy link
Contributor

tmiasko commented Aug 7, 2023

To avoid compile time impact #114568 (comment), can you also check that PGO information is available before requesting hotness data?

@Kobzol
Copy link
Member Author

Kobzol commented Aug 7, 2023

Would it be enough to just check if we're currently compiling with -Cprofile-use?

@tmiasko
Copy link
Contributor

tmiasko commented Aug 7, 2023

Checking for -Cprofile-use sounds good.

@Kobzol
Copy link
Member Author

Kobzol commented Aug 7, 2023

Ok, done.

@tmiasko
Copy link
Contributor

tmiasko commented Aug 7, 2023

@bors delegate=Kobzol

@bors
Copy link
Collaborator

bors commented Aug 7, 2023

✌️ @Kobzol, you can now approve this pull request!

If @tmiasko told you to "r=me" after making some further change, please make that change, then do @bors r=@tmiasko

@Kobzol Kobzol force-pushed the remark-pgo-hotness branch from 67bd1b1 to 9602581 Compare August 7, 2023 18:33
@Kobzol
Copy link
Member Author

Kobzol commented Aug 7, 2023

@bors r=tmiasko

@bors
Copy link
Collaborator

bors commented Aug 7, 2023

📌 Commit 960258163e22387e4c229b413de1d419bf3fec1d has been approved by tmiasko

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 7, 2023
@bors
Copy link
Collaborator

bors commented Aug 8, 2023

⌛ Testing commit 960258163e22387e4c229b413de1d419bf3fec1d with merge 51b042919f98f280adb72f8915167adcec870667...

@rust-log-analyzer

This comment has been minimized.

@bors
Copy link
Collaborator

bors commented Aug 8, 2023

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 8, 2023
@Kobzol
Copy link
Member Author

Kobzol commented Aug 8, 2023

That doesn't seem good. I don't really have x86_64-mingw prepared locally, and hints on how to debug the segfault?

@Kobzol Kobzol force-pushed the remark-pgo-hotness branch from 9602581 to 9d417d7 Compare August 8, 2023 13:37
@Kobzol
Copy link
Member Author

Kobzol commented Aug 8, 2023

Oh, ok, that's one way to solve it 😆 Thank you both.

@tmiasko
Copy link
Contributor

tmiasko commented Aug 8, 2023

@bors r+

@bors
Copy link
Collaborator

bors commented Aug 8, 2023

📌 Commit 9d417d7 has been approved by tmiasko

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 8, 2023
@bors
Copy link
Collaborator

bors commented Aug 8, 2023

⌛ Testing commit 9d417d7 with merge f525bb4...

@bors
Copy link
Collaborator

bors commented Aug 8, 2023

☀️ Test successful - checks-actions
Approved by: tmiasko
Pushing f525bb4 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Aug 8, 2023
@bors bors merged commit f525bb4 into rust-lang:master Aug 8, 2023
@rustbot rustbot added this to the 1.73.0 milestone Aug 8, 2023
@Kobzol Kobzol deleted the remark-pgo-hotness branch August 8, 2023 18:21
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (f525bb4): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
3.3% [3.3%, 3.3%] 1
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-2.4% [-2.4%, -2.4%] 2
All ❌✅ (primary) - - 0

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 631.076s -> 632.146s (0.17%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants