Skip to content

Conversation

RalfJung
Copy link
Member

@RalfJung RalfJung commented Aug 2, 2023

This is basically the rustc source code version of rust-lang/rustc-dev-guide#1471.

@rustbot
Copy link
Collaborator

rustbot commented Aug 2, 2023

r? @jackh726

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Aug 2, 2023
@rustbot
Copy link
Collaborator

rustbot commented Aug 2, 2023

Some changes occurred to the CTFE / Miri engine

cc @rust-lang/miri

Some changes occurred to the CTFE / Miri engine

cc @rust-lang/miri

@rust-log-analyzer

This comment has been minimized.

@RalfJung RalfJung force-pushed the interpret-not-miri branch from f6521b8 to 2984670 Compare August 2, 2023 14:52
@jackh726
Copy link
Member

jackh726 commented Aug 2, 2023

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Aug 2, 2023

📌 Commit 2984670 has been approved by jackh726

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 2, 2023
bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 3, 2023
…iaskrgr

Rollup of 3 pull requests

Successful merges:

 - rust-lang#114363 (avoid 'miri' when refering to the shared interpreter)
 - rust-lang#114371 (Add myself to mailmap)
 - rust-lang#114387 (Temporarily eholk from review rotation)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 01fdb9d into rust-lang:master Aug 3, 2023
@bors
Copy link
Collaborator

bors commented Aug 3, 2023

⌛ Testing commit 2984670 with merge 2e6ac7f...

@rustbot rustbot added this to the 1.73.0 milestone Aug 3, 2023
@RalfJung RalfJung deleted the interpret-not-miri branch August 3, 2023 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants