Effects: don't print host param in diagnostics
#114203
Merged
+36
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
|
Could be useful to keep printing them under -Zverbose. Or do you think it will always be obvious enough? |
|
Oh yea this was cherry picked from my old code. At some point I changed it to still print with -Zverbose but it didn't carry to this PR I guess. Will do that once I get time |
fee1-dead
force-pushed
the
effects/pp-no-host
branch
from
07aedbb to
df3f9fd
Compare
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
fee1-dead
added a commit
to fee1-dead-contrib/rust
that referenced
this pull request
Jul 30, 2023
…st, r=oli-obk Effects: don't print `host` param in diagnostics r? `@oli-obk`
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jul 30, 2023
…fee1-dead Rollup of 3 pull requests Successful merges: - rust-lang#112151 (Clarify behavior of inclusive bounds in BTreeMap::{lower,upper}_bound) - rust-lang#113512 (Updated lines doc to include trailing carriage return note) - rust-lang#114203 (Effects: don't print `host` param in diagnostics) r? `@ghost` `@rustbot` modify labels: rollup
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @oli-obk