Replace a lazy RefCell<Option<T>> with OnceCell<T>
#114155
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @b-naber (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
|
Some changes occurred to MIR optimizations cc @rust-lang/wg-mir-opt |
bors
added
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Jul 28, 2023
Replace a lazy `RefCell<Option<T>>` with `OnceCell<T>` This code was using `RefCell<Option<T>>` to manually implement lazy initialization. Now that we have `OnceCell` in the standard library, we can just use that instead. In particular, this avoids a confusing doubly-nested option, because the value being lazily computed is itself an `Option<Symbol>`.
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jul 28, 2023
…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#114099 (privacy: no nominal visibility for assoc fns ) - rust-lang#114128 (When flushing delayed span bugs, write to the ICE dump file even if it doesn't exist) - rust-lang#114138 (Adjust spans correctly for fn -> method suggestion) - rust-lang#114146 (Skip reporting item name when checking RPITIT GAT's associated type bounds hold) - rust-lang#114147 (Insert RPITITs that were shadowed by missing ADTs that resolve to [type error]) - rust-lang#114155 (Replace a lazy `RefCell<Option<T>>` with `OnceCell<T>`) - rust-lang#114164 (Add regression test for `--cap-lints allow` and trait bounds warning) r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code was using
RefCell<Option<T>>to manually implement lazy initialization. Now that we haveOnceCellin the standard library, we can just use that instead.In particular, this avoids a confusing doubly-nested option, because the value being lazily computed is itself an
Option<Symbol>.