Remove `constness` from `ParamEnv` #114134

fee1-dead · 2023-07-27T15:53:09Z

This should be replaced by keyword generics/effects. cc #110395

r? @oli-obk

rustbot · 2023-07-27T15:53:25Z

Some changes occurred in src/tools/clippy

cc @rust-lang/clippy

Some changes occurred to the CTFE / Miri engine

cc @rust-lang/miri

Some changes occurred to the core trait solver

cc @rust-lang/initiative-trait-system-refactor

Some changes occurred to the CTFE / Miri engine

cc @rust-lang/miri

src/tools/clippy/clippy_lints/src/manual_float_methods.rs

oli-obk · 2023-07-28T07:20:53Z

@bors r+

bors · 2023-07-28T07:20:55Z

📌 Commit b0fa220 has been approved by oli-obk

It is now in the queue for this repository.

bors · 2023-07-28T08:53:21Z

⌛ Testing commit b0fa220 with merge aafd75a...

bors · 2023-07-28T10:40:51Z

☀️ Test successful - checks-actions
Approved by: oli-obk
Pushing aafd75a to master...

rust-timer · 2023-07-28T21:04:34Z

Finished benchmarking commit (aafd75a): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.4%	[-0.6%, -0.3%]	23
Improvements ✅ (secondary)	-0.5%	[-0.7%, -0.3%]	16
All ❌✅ (primary)	-0.4%	[-0.6%, -0.3%]	23

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.3%	[-3.1%, -1.6%]	2
All ❌✅ (primary)	-	-	0

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.4%	[-2.6%, -2.3%]	3
All ❌✅ (primary)	-	-	0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 652.048s -> 651.183s (-0.13%)

…param-env, r=oli-obk Remove `constness` from `ParamEnv` This should be replaced by keyword generics/effects. cc rust-lang#110395 r? `@oli-obk`

…r=lcnr Don't require `Drop` for `[PhantomData<T>; N]` where `N` and `T` are generic, if `T` requires `Drop` fixes rust-lang#115403 fixes rust-lang#115410 This was accidentally regressed in rust-lang#114134, because it was accidentally stabilized in rust-lang#102204 (cc `@rust-lang/lang,` seems like an innocent stabilization, considering this PR is more of a bugfix than a feature). While we have a whole month to beta backport this change before the regression hits stable, I'd still prefer not to go through an FCP on this PR (which fixes a regression), if T-lang wants an FCP, I can can open an issue about the change itself.

Don't require `Drop` for `[PhantomData<T>; N]` where `N` and `T` are generic, if `T` requires `Drop` fixes rust-lang/rust#115403 fixes rust-lang/rust#115410 This was accidentally regressed in rust-lang/rust#114134, because it was accidentally stabilized in #102204 (cc `@rust-lang/lang,` seems like an innocent stabilization, considering this PR is more of a bugfix than a feature). While we have a whole month to beta backport this change before the regression hits stable, I'd still prefer not to go through an FCP on this PR (which fixes a regression), if T-lang wants an FCP, I can can open an issue about the change itself.

…er-errors const traits: remove some known-bug that do not seem to make sense These tests were made to point to rust-lang#103507 in rust-lang#114134; I think that was a mistake: that issue is about a rather specific problem, and most tests marked as known-bug in that PR are pointing at rust-lang#110395 which makes more sense. Of the 4 tests that still point to rust-lang#103507: - One is [the original test](https://github.com/rust-lang/rust/blob/20882608529a969bd878ad787cf0038716c021df/tests/ui/impl-trait/normalize-tait-in-const.rs). It still fails to compile, though currently for unrelated reasons (`~const Fn` is not valid as that is not a const trait). I made it point at rust-lang#110395 like all the other tests that were disabled when the previous const trait impl was removed. - One is being fixed in rust-lang#135423 - The other two are fixed in this PR The errors we are getting here are not great but they do look correct? FWIW there are still a whole lot of tests mentioning rust-lang#110395 despite that issue being closed... I hope someone is tracking that.^^ r? `@compiler-errors`

Rollup merge of rust-lang#135523 - RalfJung:wrong-known-bug, r=compiler-errors const traits: remove some known-bug that do not seem to make sense These tests were made to point to rust-lang#103507 in rust-lang#114134; I think that was a mistake: that issue is about a rather specific problem, and most tests marked as known-bug in that PR are pointing at rust-lang#110395 which makes more sense. Of the 4 tests that still point to rust-lang#103507: - One is [the original test](https://github.com/rust-lang/rust/blob/20882608529a969bd878ad787cf0038716c021df/tests/ui/impl-trait/normalize-tait-in-const.rs). It still fails to compile, though currently for unrelated reasons (`~const Fn` is not valid as that is not a const trait). I made it point at rust-lang#110395 like all the other tests that were disabled when the previous const trait impl was removed. - One is being fixed in rust-lang#135423 - The other two are fixed in this PR The errors we are getting here are not great but they do look correct? FWIW there are still a whole lot of tests mentioning rust-lang#110395 despite that issue being closed... I hope someone is tracking that.^^ r? `@compiler-errors`

fee1-dead added 2 commits July 27, 2023 15:50

Remove constness from ParamEnv

e6b423a

update tests, adding known-bug

2d59451

rustbot assigned oli-obk Jul 27, 2023

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver) labels Jul 27, 2023

fee1-dead marked this pull request as ready for review July 27, 2023 15:53

blyxyas reviewed Jul 27, 2023

View reviewed changes

src/tools/clippy/clippy_lints/src/manual_float_methods.rs Show resolved Hide resolved

This comment has been minimized.

Sign in to view

bless clippy

b0fa220

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 28, 2023

bors added the merged-by-bors This PR was explicitly merged by bors. label Jul 28, 2023

bors merged commit aafd75a into rust-lang:master Jul 28, 2023

rustbot added this to the 1.73.0 milestone Jul 28, 2023

This was referenced Jul 28, 2023

Implement unification of const abstract impls #104803

Closed

Cleaner assert_eq! & assert_ne! panic messages #111071

Merged

Change default panic handler message format. #112849

Merged

Implement generic const items #113522

Merged

lcnr removed the WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver) label Jul 28, 2023

matthiaskrgr mentioned this pull request Jul 28, 2023

ice: assertion failed: promoted.is_none() || Q::ALLOW_PROMOTED' #114179

Closed

fee1-dead deleted the rm-constness-from-param-env branch July 29, 2023 08:11

fee1-dead mentioned this pull request May 21, 2023

Tracking Issue for removing impl const and ~const in the standard library #110395

Closed

4 tasks

oli-obk mentioned this pull request Sep 4, 2023

Don't require Drop for [PhantomData<T>; N] where N and T are generic, if T requires Drop #115527

Merged

matthiaskrgr mentioned this pull request Nov 7, 2023

[ICE]: ICE error when using async_fn_in_trait and const_trait_impl features simultaneously #117634

Closed

4 tasks

fee1-dead mentioned this pull request Dec 12, 2023

Restore const PartialEq #118661

Merged

matthiaskrgr mentioned this pull request Feb 11, 2024

ICE: const parameter types cannot be generic #120941

Closed

Nadrieril mentioned this pull request May 28, 2024

Bump rustc version cryspen/hax#690

Merged

This was referenced Jan 14, 2025

Enforce syntactical stability of const traits in HIR #135423

Merged

const traits: remove some known-bug that do not seem to make sense #135523

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Remove `constness` from `ParamEnv` #114134

Remove `constness` from `ParamEnv` #114134

Uh oh!

fee1-dead commented Jul 27, 2023 •

edited

Loading

Uh oh!

rustbot commented Jul 27, 2023

Uh oh!

Uh oh!

This comment has been minimized.

oli-obk commented Jul 28, 2023

Uh oh!

bors commented Jul 28, 2023

Uh oh!

bors commented Jul 28, 2023

Uh oh!

bors commented Jul 28, 2023

Uh oh!

rust-timer commented Jul 28, 2023

Uh oh!

Uh oh!

Remove constness from ParamEnv #114134

Remove constness from ParamEnv #114134

Uh oh!

Conversation

fee1-dead commented Jul 27, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Jul 27, 2023

Uh oh!

Uh oh!

This comment has been minimized.

oli-obk commented Jul 28, 2023

Uh oh!

bors commented Jul 28, 2023

Uh oh!

bors commented Jul 28, 2023

Uh oh!

bors commented Jul 28, 2023

Uh oh!

rust-timer commented Jul 28, 2023

Overall result: ✅ improvements - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

Uh oh!

Remove `constness` from `ParamEnv` #114134

Remove `constness` from `ParamEnv` #114134

fee1-dead commented Jul 27, 2023 •

edited

Loading