Skip to content

Conversation

GuillaumeGomez
Copy link
Member

Fixes #113982.

The attributes were not merged with the import's in case of glob re-export of foreign items.

r? @notriddle

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Jul 24, 2023
@notriddle
Copy link
Contributor

@bors r+

@bors
Copy link
Collaborator

bors commented Jul 26, 2023

📌 Commit 7150e35 has been approved by notriddle

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 26, 2023
@bors
Copy link
Collaborator

bors commented Jul 26, 2023

⌛ Testing commit 7150e35 with merge 6908c73...

@bors
Copy link
Collaborator

bors commented Jul 26, 2023

☀️ Test successful - checks-actions
Approved by: notriddle
Pushing 6908c73 to master...

1 similar comment
@bors
Copy link
Collaborator

bors commented Jul 26, 2023

☀️ Test successful - checks-actions
Approved by: notriddle
Pushing 6908c73 to master...

@bors bors added merged-by-bors This PR was explicitly merged by bors. labels Jul 26, 2023
@bors bors merged commit 6908c73 into rust-lang:master Jul 26, 2023
@rustbot rustbot added this to the 1.73.0 milestone Jul 26, 2023
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (6908c73): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-2.6% [-3.1%, -2.0%] 2
All ❌✅ (primary) - - 0

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
3.2% [2.0%, 5.2%] 22
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) - - 0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 650.146s -> 650.44s (0.05%)

@GuillaumeGomez GuillaumeGomez deleted the fix-113982 branch August 19, 2024 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Doc feature banners won't show up when re-exporting items with wildcard
6 participants