Skip to content

a small fn needs_drop refactor #113824

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 18, 2023
Merged

a small fn needs_drop refactor #113824

merged 2 commits into from
Jul 18, 2023

Conversation

lcnr
Copy link
Contributor

@lcnr lcnr commented Jul 18, 2023 •
edited
Loading

I am generally a fan of exhaustively matching on TyKind once we care about more than 1 variant

@rustbot
Copy link
Collaborator

rustbot commented Jul 18, 2023

r? @wesleywiser

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jul 18, 2023
@lcnr lcnr changed the title needs_drop use exhaustive match a small fn needs_drop refactor Jul 18, 2023
@lcnr lcnr force-pushed the exhaustive-match branch from a359c3b to d1b7f1b Compare July 18, 2023 13:37
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@lcnr
some additional refactor
d1b4b45 
also, treat placeholders equal to params
@lcnr lcnr force-pushed the exhaustive-match branch from d1b7f1b to d1b4b45 Compare July 18, 2023 13:50
wesleywiser
wesleywiser approved these changes Jul 18, 2023
View reviewed changes
Copy link
Member

@wesleywiser wesleywiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, exhaustively matching TyKind is usually better. Thanks for doing this!

@wesleywiser
Copy link
Member

r=me when CI is green

@lcnr
Copy link
Contributor Author

lcnr commented Jul 18, 2023

@bors r=wesleywiser rollup

@bors
Copy link
Collaborator

bors commented Jul 18, 2023

📌 Commit d1b4b45 has been approved by wesleywiser

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 18, 2023
@matthiaskrgr matthiaskrgr mentioned this pull request Jul 18, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 18, 2023
@bors
Auto merge of rust-lang#113837 - matthiaskrgr:rollup-v4xud4s, r=matth…
42a982d 
…iaskrgr

Rollup of 6 pull requests

Successful merges:

 - rust-lang#113811 (Fix removal span calculation of `unused_qualifications` suggestion)
 - rust-lang#113812 (docs(release): Remove nightly-only cargo item)
 - rust-lang#113823 (Fix results search alias display)
 - rust-lang#113824 (a small `fn needs_drop` refactor)
 - rust-lang#113828 (Ping spastorino on changes to SMIR)
 - rust-lang#113832 (Add `#[track_caller]` to lint related diagnostic functions)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 994e2e4 into rust-lang:master Jul 18, 2023
@rustbot rustbot added this to the 1.73.0 milestone Jul 18, 2023
@lcnr lcnr deleted the exhaustive-match branch July 20, 2023 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wesleywiser wesleywiser wesleywiser approved these changes

Assignees

@wesleywiser wesleywiser

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.73.0
Development

Successfully merging this pull request may close these issues.
5 participants
@lcnr @rustbot @rust-log-analyzer @wesleywiser @bors