Revert "alloc: Allow comparing Boxs over different allocators", add regression test #113318
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @m-ou-se (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
|
(reviewer of the original commit) |
…st-lang#113283) Verify that `PartialEq` implementations do not break type inference when comparing types across different allocators. This catches a regression in current nightly introduced in 001b081 (alloc: Allow comparing `Box`s over different allocators") `Box` is the only type that currently impelements this, but tests are included for `Rc` and `Arc` to prevent future regresssions.
This reverts commit 001b081. This change was done as the above commit introduces a regression in type inference. Regression test located at `tests/ui/type-inference/issue-113283-alllocator-trait-eq.rs`
tgross35
force-pushed
the
113283-allocator-trait-eq
branch
from
7a6a6c4 to
a635bf7
Compare
tgross35
changed the title
PartialEq across Allocators breaking inference, revert this commitPartialEq across Allocators breaking inference, revert the relevant commit
|
@rustbot label -T-libs +T-libs-api |
rustbot
added
T-libs-api
tgross35
changed the title
PartialEq across Allocators breaking inference, revert the relevant commit
|
|
|
@bors r+ |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jul 7, 2023
…mpiler-errors Rollup of 8 pull requests Successful merges: - rust-lang#111917 (Simplify duplicate checks for mir validator) - rust-lang#112008 (Fix incorrect documented default bufsize in bufreader/writer) - rust-lang#112825 (Don't call `type_of` on TAIT in defining scope in new solver) - rust-lang#113164 (Add a regression test for rust-lang#109054) - rust-lang#113318 (Revert "alloc: Allow comparing Boxs over different allocators", add regression test) - rust-lang#113397 (Prefer object candidates in new selection) - rust-lang#113419 (Avoid calling item_name for RPITIT) - rust-lang#113421 (Do not assert >1 RPITITs on collect_return_position_impl_trait_in_trait_tys) r? `@ghost` `@rustbot` modify labels: rollup
smoelius
added a commit
to trailofbits/necessist
that referenced
this pull request
Jul 7, 2023
rust-lang/rust#113318 was merged.
smoelius
added a commit
to trailofbits/necessist
that referenced
this pull request
Jul 7, 2023
rust-lang/rust#113318 was merged.
smoelius
added a commit
to trailofbits/necessist
that referenced
this pull request
Jul 10, 2023
rust-lang/rust#113318 was merged.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Temporary fix for #113283
Adds a test to fix the regression introduced in 001b081 and revert that commit. The test fails without the revert.