Skip to content

Conversation

mu001999
Copy link
Contributor

@mu001999 mu001999 commented Jul 3, 2023

Fixes #113222

The nicer suggestion for dev-channel won't be emitted if -Z ui-testing enabled. IMO, this is acceptable for now.

@rustbot
Copy link
Collaborator

rustbot commented Jul 3, 2023

r? @eholk

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jul 3, 2023
@mu001999
Copy link
Contributor Author

mu001999 commented Jul 3, 2023

r? @Nilstrieb

@rustbot rustbot assigned Noratrieb and unassigned eholk Jul 3, 2023
@bors
Copy link
Collaborator

bors commented Jul 3, 2023

☔ The latest upstream changes (presumably #113288) made this pull request unmergeable. Please resolve the merge conflicts.

@mu001999 mu001999 force-pushed the fix/issue-113222 branch from 8c5dd85 to 9b6bdcd Compare July 4, 2023 01:40
Copy link
Member

@Noratrieb Noratrieb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested it locally with x test tests/ui and it passed.

@Noratrieb
Copy link
Member

@bors r+

@bors
Copy link
Collaborator

bors commented Aug 2, 2023

📌 Commit 9b6bdcd has been approved by Nilstrieb

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 2, 2023
@bors
Copy link
Collaborator

bors commented Aug 3, 2023

⌛ Testing commit 9b6bdcd with merge aa70e5f...

@bors
Copy link
Collaborator

bors commented Aug 3, 2023

☀️ Test successful - checks-actions
Approved by: Nilstrieb
Pushing aa70e5f to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Aug 3, 2023
@bors bors merged commit aa70e5f into rust-lang:master Aug 3, 2023
@rustbot rustbot added this to the 1.73.0 milestone Aug 3, 2023
@mu001999 mu001999 deleted the fix/issue-113222 branch August 3, 2023 03:06
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (aa70e5f): comparison URL.

Overall result: ❌ regressions - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
0.7% [0.7%, 0.7%] 2
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 0.7% [0.7%, 0.7%] 2

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
2.0% [1.9%, 2.0%] 2
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-1.3% [-1.3%, -1.3%] 1
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 0.9% [-1.3%, 2.0%] 3

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-4.9% [-4.9%, -4.9%] 1
All ❌✅ (primary) - - 0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 648.105s -> 647.209s (-0.14%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Suggest x build library for a custom toolchain that fails to load core
6 participants