Skip to content

rustdoc: handle assoc const equalities in cross-crate APIT #113028

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 25, 2023
Merged

rustdoc: handle assoc const equalities in cross-crate APIT #113028

merged 1 commit into from
Jun 25, 2023

Conversation

fmease
Copy link
Member

@fmease fmease commented Jun 25, 2023 •
edited
Loading

Fixes FIXME (the added test previously lead to an ICE).

@rustbot label A-cross-crate-reexports

@rustbot
Copy link
Collaborator

rustbot commented Jun 25, 2023

r? @notriddle

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. A-cross-crate-reexports Area: Documentation that has been re-exported from a different crate labels Jun 25, 2023
@notriddle
Copy link
Contributor

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Jun 25, 2023

📌 Commit 247aa06 has been approved by notriddle

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 25, 2023
@TaKO8Ki TaKO8Ki mentioned this pull request Jun 25, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 25, 2023
@bors
Auto merge of rust-lang#113037 - TaKO8Ki:rollup-pqfbxwk, r=TaKO8Ki
8084f39 
Rollup of 3 pull requests

Successful merges:

 - rust-lang#112281 (Test the cargo args generated by bootstrap.py)
 - rust-lang#113028 (rustdoc: handle assoc const equalities in cross-crate impl-Trait-in-arg-pos)
 - rust-lang#113029 (CI: do not run Bump dependencies workflow on forks)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 019f43e into rust-lang:master Jun 25, 2023
@rustbot rustbot added this to the 1.72.0 milestone Jun 25, 2023
@fmease fmease deleted the rustdoc-x-crate-itiap-clean-term branch June 25, 2023 21:00
@fmease fmease changed the title rustdoc: handle assoc const equalities in cross-crate impl-Trait-in-arg-pos rustdoc: handle assoc const equalities in cross-crate APIT Jul 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@notriddle notriddle

Labels
A-cross-crate-reexports Area: Documentation that has been re-exported from a different crate S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.72.0
Development

Successfully merging this pull request may close these issues.
4 participants
@fmease @rustbot @notriddle @bors