Fix rustdoc-gui tests on Windows #112613
Merged
Fix rustdoc-gui tests on Windows #112613
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
A-testsuite
|
Nice! this with #112562 allows running rustdoc-gui on x86_64-pc-windows-msvc target. |
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 14, 2023
…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#112584 (loongarch64-none*: Remove environment component from llvm target) - rust-lang#112600 (Introduce a `Stable` trait to translate MIR to SMIR) - rust-lang#112605 (Improve docs/clean up negative overlap functions) - rust-lang#112611 (Error on unconstrained lifetime in RPITIT) - rust-lang#112612 (Fix explicit-outlives-requirements lint span) - rust-lang#112613 (Fix rustdoc-gui tests on Windows) - rust-lang#112620 (Fix small typo) r? `@ghost` `@rustbot` modify labels: rollup
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Jun 15, 2023
…eGomez rustdoc-gui: allow running on Windows This adds few fixes to allow running `python x.py test rustdoc-gui` on Windows. * path to npm required to be `npm.cmd` on Windows (otherwise don't work for me) * properly parse node module version on Windows * properly provide path to browser-ui-test runner (fixed in rust-lang#112613) r? `@GuillaumeGomez`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The browser-ui-test update contains fixes needed for backslash handling (they were not correctly escaped).
Since we have a mix of slash and backslash in some tests, I replaced
DOC_FOLDERvariable backslashes with slashes.And finally it seemed like the unicode escaped wasn't much appreciated on Windows for some reason so I used the character directly.
cc @klensy
r? @notriddle