Skip to content

Conversation

clubby789
Copy link
Contributor

cc #100717

@rustbot
Copy link
Collaborator

rustbot commented Apr 25, 2023

r? @compiler-errors

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Apr 25, 2023
@clubby789 clubby789 mentioned this pull request Apr 25, 2023
84 tasks
@rust-log-analyzer

This comment has been minimized.

@clubby789 clubby789 force-pushed the rustc-passes-diagnostics branch from e146b3c to cebe19f Compare April 25, 2023 19:32
@clubby789 clubby789 force-pushed the rustc-passes-diagnostics branch from cebe19f to d518fb4 Compare April 25, 2023 20:02
Copy link
Member

@compiler-errors compiler-errors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good except for one nit, take it or leave it 😸

@compiler-errors
Copy link
Member

@bors delegate+

@bors
Copy link
Collaborator

bors commented Apr 26, 2023

✌️ @clubby789 can now approve this pull request

@clubby789 clubby789 force-pushed the rustc-passes-diagnostics branch from d518fb4 to ddac20e Compare April 26, 2023 02:40
@rust-log-analyzer

This comment has been minimized.

@clubby789
Copy link
Contributor Author

Oops - I'll fix that soon, as long as the new WET approach looks good?

@compiler-errors
Copy link
Member

Looks fine to me, though I would probably just inline report_unused_assign to avoid having to pass true/false. It's a small enough body that the duplication is probably fine...

@compiler-errors
Copy link
Member

Either that, or make a different enum instead of using a boolean. No strong opinion.

@clubby789 clubby789 force-pushed the rustc-passes-diagnostics branch from ddac20e to 6a41cfe Compare April 26, 2023 10:40
@clubby789
Copy link
Contributor Author

@bors r=compiler-errors

@bors
Copy link
Collaborator

bors commented Apr 26, 2023

📌 Commit 6a41cfe has been approved by compiler-errors

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 26, 2023
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Apr 26, 2023
…, r=compiler-errors

Migrate `rustc_passes` to translatable diagnostics

cc rust-lang#100717
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Apr 27, 2023
…, r=compiler-errors

Migrate `rustc_passes` to translatable diagnostics

cc rust-lang#100717
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 27, 2023
…iaskrgr

Rollup of 7 pull requests

Successful merges:

 - rust-lang#110426 (docs(style): add more let-else examples)
 - rust-lang#110804 (Remove repeated definite articles)
 - rust-lang#110814 (Sprinkle some `#[inline]` in `rustc_data_structures::tagged_ptr`)
 - rust-lang#110816 (Migrate `rustc_passes` to translatable diagnostics)
 - rust-lang#110864 (`IntoFuture::into_future` is no longer unstable)
 - rust-lang#110866 (Make `method-not-found-generic-arg-elision.rs` error message not path dependent)
 - rust-lang#110872 (Nicer ICE for rust-lang#67981)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 63fbb05 into rust-lang:master Apr 27, 2023
@rustbot rustbot added this to the 1.71.0 milestone Apr 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants