Skip to content

Panic instead of truncating if the incremental on-disk cache is too big #110632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 21, 2023
Merged

Panic instead of truncating if the incremental on-disk cache is too big #110632

merged 1 commit into from
Apr 21, 2023

Conversation

saethlin
Copy link
Member

It seems unlikely that anyone would hit this truncation, but if this as does actually truncate, that seems incredibly bad.

@rustbot
Copy link
Collaborator

rustbot commented Apr 21, 2023

r? @lcnr

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added A-query-system Area: The rustc query system (https://rustc-dev-guide.rust-lang.org/query.html) S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Apr 21, 2023
@lcnr
Copy link
Contributor

lcnr commented Apr 21, 2023

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Apr 21, 2023

📌 Commit 010deb5 has been approved by lcnr

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 21, 2023
@cjgillot cjgillot changed the title Panic instead of truncating if the dep graph is too big Panic instead of truncating if the incremental on-disk cache is too big Apr 21, 2023
@Dylan-DPC Dylan-DPC mentioned this pull request Apr 21, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 21, 2023
@bors
Auto merge of rust-lang#110648 - Dylan-DPC:rollup-em3ovcq, r=Dylan-DPC
fec9adc 
Rollup of 5 pull requests

Successful merges:

 - rust-lang#110333 (rustc_metadata: Split `children` into multiple tables)
 - rust-lang#110501 (rustdoc: fix ICE from rustc_resolve and librustdoc parse divergence)
 - rust-lang#110608 (Specialize some `io::Read` and `io::Write` methods for `VecDeque<u8>` and `&[u8]`)
 - rust-lang#110632 (Panic instead of truncating if the incremental on-disk cache is too big)
 - rust-lang#110633 (More `mem::take` in `library`)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 1d1453a into rust-lang:master Apr 21, 2023
@rustbot rustbot added this to the 1.71.0 milestone Apr 21, 2023
@saethlin saethlin deleted the panic-if-dep-graph-too-big branch April 28, 2023 16:43
@saethlin saethlin mentioned this pull request May 16, 2023
Closed
This was referenced Jul 1, 2023
Closed
Closed
@saethlin saethlin mentioned this pull request Sep 4, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@lcnr lcnr

Labels
A-query-system Area: The rustc query system (https://rustc-dev-guide.rust-lang.org/query.html) S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.71.0
Development

Successfully merging this pull request may close these issues.
4 participants
@saethlin @rustbot @lcnr @bors