Skip to content

fix(doc): do not parse inline when output is json for external crate #110146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 11, 2023
Merged

fix(doc): do not parse inline when output is json for external crate #110146

merged 1 commit into from
Apr 11, 2023

Conversation

bvanjoi
Copy link
Contributor

@bvanjoi bvanjoi commented Apr 10, 2023

relative #110138

@rustbot
Copy link
Collaborator

rustbot commented Apr 10, 2023

r? @jsha

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Apr 10, 2023
@rustbot
Copy link
Collaborator

rustbot commented Apr 10, 2023

Some changes occurred in src/librustdoc/clean/types.rs

cc @camelid

@notriddle
Copy link
Contributor

r? @notriddle

@rustbot rustbot assigned notriddle and unassigned jsha Apr 10, 2023
@notriddle
Copy link
Contributor

@bors r+ rollup

Thanks a bunch!

@bors
Copy link
Collaborator

bors commented Apr 10, 2023

📌 Commit c127020 has been approved by notriddle

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 10, 2023
@JohnTitor JohnTitor mentioned this pull request Apr 11, 2023
Closed
JohnTitor added a commit to JohnTitor/rust that referenced this pull request Apr 11, 2023
@JohnTitor
Rollup merge of rust-lang#110146 - bvanjoi:relative-110138, r=notriddle
7aa7496 
fix(doc): do not parse inline when output is json for external crate

relative rust-lang#110138
@JohnTitor JohnTitor mentioned this pull request Apr 11, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 11, 2023
@bors
Auto merge of rust-lang#110170 - JohnTitor:rollup-hdramer, r=JohnTitor
5072826 
Rollup of 8 pull requests

Successful merges:

 - rust-lang#109527 (Set up standard library path substitution in rust-gdb and gdbgui)
 - rust-lang#109752 (Stall auto trait assembly in new solver for int/float vars)
 - rust-lang#109860 (Add support for RISC-V relax target feature)
 - rust-lang#109923 (Update `error [E0449]: unnecessary visibility qualifier` to be more clear)
 - rust-lang#110070 (The `wrapping_neg` example for unsigned types shouldn't use `i8`)
 - rust-lang#110146 (fix(doc): do not parse inline when output is json for external crate)
 - rust-lang#110147 (Add regression test for rust-lang#104916)
 - rust-lang#110149 (Update books)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit a996418 into rust-lang:master Apr 11, 2023
@rustbot rustbot added this to the 1.70.0 milestone Apr 11, 2023
@GuillaumeGomez GuillaumeGomez mentioned this pull request Apr 12, 2023
Closed
@bvanjoi bvanjoi deleted the relative-110138 branch May 20, 2023 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@notriddle notriddle

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.70.0
Development

Successfully merging this pull request may close these issues.
5 participants
@bvanjoi @rustbot @notriddle @bors @jsha